-
Notifications
You must be signed in to change notification settings - Fork 254
Open
Description
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch react-native-popup-menu@0.16.1
for the project I'm working on.
I got the issue from sentry in production. I think it was caused by some render issues. Just add this to avoid the unknown issue.
Here is the diff that solved my problem:
diff --git a/node_modules/react-native-popup-menu/src/MenuOption.js b/node_modules/react-native-popup-menu/src/MenuOption.js
index bc944ef..fc37090 100644
--- a/node_modules/react-native-popup-menu/src/MenuOption.js
+++ b/node_modules/react-native-popup-menu/src/MenuOption.js
@@ -20,6 +20,9 @@ export class MenuOption extends Component {
_getMenusOnSelect() {
const menu = this.props.ctx.menuActions._getOpenedMenu();
+ if(!menu) {
+ return () => true
+ }
return menu.instance.props.onSelect;
}
This issue body was partially generated by patch-package.
Metadata
Metadata
Assignees
Labels
No labels