Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Commit 149421c

Browse files
Fix testGetAllAssets test
1 parent 6742255 commit 149421c

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

SeleniumGridExtras/src/test/java/com/groupon/seleniumgridextras/downloader/GridExtrasDownloaderTest.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,17 @@ public void testGetCachedReleaseList() throws Exception {
8686

8787
long msRange = TimeStampUtility.timestampInMs() - downloader.getCachedReleaseResponseFile().lastModified();
8888
assertTrue(msRange < 10000); //Make sure that file created is no older than 10 seconds
89+
System.out.println("INITIAL RESPONSE : " + initialResponse);
90+
System.out.println("downloader.getCachedReleaseList() : " + downloader.getCachedReleaseList());
8991
assertEquals(initialResponse, downloader.getCachedReleaseList());
9092

9193
Thread.sleep(5000);
9294
//Let file expire and try to download cached file again, make sure response is still the same
9395
//But the file gets re-written
9496

9597
assertEquals(initialResponse, downloader.getCachedReleaseList());
98+
System.out.println("INITIAL RESPONSE : " + initialResponse);
99+
System.out.println("downloader.getCachedReleaseList() : " + downloader.getCachedReleaseList());
96100
long msRange2 = TimeStampUtility.timestampInMs() - downloader.getCachedReleaseResponseFile().lastModified();
97101
assertTrue(msRange2 < 2000); //Make sure that file created is no older than 2 seconds
98102
}
@@ -156,22 +160,24 @@ public void testBadVersion() throws Exception {
156160

157161
@Test
158162
public void testGetAllAssets() throws Exception {
163+
String expectedVersionOldest = "1.2.3";
164+
String expectedVersionFifthOldest = "1.3.3";
159165
List<Map<String, String>> actual = downloader.getAllDownloadableAssets();
160166
int actualSize = actual.size();
161167

162168
assertTrue(actualSize > 0);
163169

164-
assertEquals("SeleniumGridExtras-1.1.9-SNAPSHOT-jar-with-dependencies.jar",
170+
assertEquals("SeleniumGridExtras-" + expectedVersionOldest +"-SNAPSHOT-jar-with-dependencies.jar",
165171
actual.get(actualSize - 1).keySet().toArray()[0]);
166172

167-
assertEquals("https://github.com/groupon/Selenium-Grid-Extras/releases/download/1.1.9/SeleniumGridExtras-1.1.9-SNAPSHOT-jar-with-dependencies.jar",
173+
assertEquals("https://github.com/groupon/Selenium-Grid-Extras/releases/download/v" + expectedVersionOldest + "/SeleniumGridExtras-" + expectedVersionOldest + "-SNAPSHOT-jar-with-dependencies.jar",
168174
actual.get(actualSize - 1).values().toArray()[0]);
169175

170176

171-
assertEquals("SeleniumGridExtras-1.2.4-SNAPSHOT-jar-with-dependencies.jar",
177+
assertEquals("SeleniumGridExtras-" + expectedVersionFifthOldest + "-SNAPSHOT-jar-with-dependencies.jar",
172178
actual.get(actualSize - 5).keySet().toArray()[0]);
173179

174-
assertEquals("https://github.com/groupon/Selenium-Grid-Extras/releases/download/v1.2.4/SeleniumGridExtras-1.2.4-SNAPSHOT-jar-with-dependencies.jar",
180+
assertEquals("https://github.com/groupon/Selenium-Grid-Extras/releases/download/v" + expectedVersionFifthOldest + "/SeleniumGridExtras-" + expectedVersionFifthOldest + "-SNAPSHOT-jar-with-dependencies.jar",
175181
actual.get(actualSize - 5).values().toArray()[0]);
176182
}
177183

0 commit comments

Comments
 (0)