Skip to content

Commit 960eff4

Browse files
committed
Submitting review 39155d2
Fixed updateThreadsStatus to modify original thread instances, rather than modifying copies This is a proposed fix to #22 `updateThreadsStatus` was not actually updating the CommentThread instances, but updating copies thereof.
2 parents d2213d9 + 39155d2 commit 960eff4

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

review/review.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ func updateThreadsStatus(threads []CommentThread) *bool {
8282
sort.Sort(byTimestamp(threads))
8383
noUnresolved := true
8484
var result *bool
85-
for _, thread := range threads {
85+
for i := range threads {
86+
thread := &threads[i]
8687
thread.updateResolvedStatus()
8788
if thread.Resolved != nil {
8889
noUnresolved = noUnresolved && *thread.Resolved

0 commit comments

Comments
 (0)