-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Open
Labels
triageNeeds to be looked atNeeds to be looked at
Description
Description
Steps to reproduce
on GitLens v17.3.0
-
Connect GitHub and Azure on GKDev
-
Sync integrations in GitLens
-
Go to Azure OAuth settings and reject the application (keep it connected on GKDev)
-
Wait for 30min until the azure token expires
-
Open the launchpad
Expected result
You see GitHub PRs
Actual result
You fail seeing any PRs, because of Azure error:

Technical details
It feels like it's here:
vscode-gitlens/src/plus/integrations/integrationService.ts
Lines 716 to 756 in 6dfa541
private async getMyPullRequestsCore( | |
integrations: Map<GitHostIntegration, ResourceDescriptor[] | undefined>, | |
cancellation?: CancellationToken, | |
silent?: boolean, | |
): Promise<IntegrationResult<PullRequest[] | undefined>> { | |
const start = Date.now(); | |
const promises: Promise<IntegrationResult<PullRequest[] | undefined>>[] = []; | |
for (const [integration, repos] of integrations) { | |
if (integration == null) continue; | |
promises.push(integration.searchMyPullRequests(repos, cancellation, silent)); | |
} | |
const results = await Promise.allSettled(promises); | |
const errors = [ | |
...filterMap(results, r => | |
r.status === 'fulfilled' && r.value?.error != null ? r.value.error : undefined, | |
), | |
]; | |
if (errors.length) { | |
return { | |
error: errors.length === 1 ? errors[0] : new AggregateError(errors), | |
duration: Date.now() - start, | |
}; | |
} | |
return { | |
value: [ | |
...flatten( | |
filterMap(results, r => | |
r.status === 'fulfilled' && r.value != null && r.value?.error == null | |
? r.value.value | |
: undefined, | |
), | |
), | |
], | |
duration: Date.now() - start, | |
}; | |
} |
Maybe we should not fail the whole procedure if one of integrations fails?
GitLens Version
17.3.0
VS Code Version
No response
Git Version
No response
Logs, Screenshots, Screen Captures, etc
No response
d13
Metadata
Metadata
Assignees
Labels
triageNeeds to be looked atNeeds to be looked at