Skip to content

Bad credential of one integration ruins other integrations on Launchpad #4492

@sergeibbb

Description

@sergeibbb

Description

Steps to reproduce

on GitLens v17.3.0

  • Connect GitHub and Azure on GKDev

  • Sync integrations in GitLens

  • Go to Azure OAuth settings and reject the application (keep it connected on GKDev)
    Image

  • Wait for 30min until the azure token expires

  • Open the launchpad

Expected result

You see GitHub PRs

Actual result

You fail seeing any PRs, because of Azure error:

Image

Technical details

It feels like it's here:

private async getMyPullRequestsCore(
integrations: Map<GitHostIntegration, ResourceDescriptor[] | undefined>,
cancellation?: CancellationToken,
silent?: boolean,
): Promise<IntegrationResult<PullRequest[] | undefined>> {
const start = Date.now();
const promises: Promise<IntegrationResult<PullRequest[] | undefined>>[] = [];
for (const [integration, repos] of integrations) {
if (integration == null) continue;
promises.push(integration.searchMyPullRequests(repos, cancellation, silent));
}
const results = await Promise.allSettled(promises);
const errors = [
...filterMap(results, r =>
r.status === 'fulfilled' && r.value?.error != null ? r.value.error : undefined,
),
];
if (errors.length) {
return {
error: errors.length === 1 ? errors[0] : new AggregateError(errors),
duration: Date.now() - start,
};
}
return {
value: [
...flatten(
filterMap(results, r =>
r.status === 'fulfilled' && r.value != null && r.value?.error == null
? r.value.value
: undefined,
),
),
],
duration: Date.now() - start,
};
}

Maybe we should not fail the whole procedure if one of integrations fails?

GitLens Version

17.3.0

VS Code Version

No response

Git Version

No response

Logs, Screenshots, Screen Captures, etc

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    triageNeeds to be looked at

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions