Version comparison fails on things like 1.9 -> 1.10

[geerlingguy]

I just ran this on drupal-vm today and got:

   - name: geerlingguy.java
-    version: 1.10.0
+    version: 1.9.7

So... the version comparison is definitely not working as planned.

[gotmax23]

Hi Jeff,

I came here after seeing your Ansible Fest presentation. Great job with that, by the way!

ansible-requirements-updater/tasks/update-requirement.yml

Lines 19 to 33 in 388c5f2

	- name: Set versions as fact.
	set_fact:
	role_versions: "{{ (role_metadata.content | from_json).summary_fields.versions }}"
	# Note: This is a pretty fragile sort. It works for strict semver... mostly, but
	# it might not work with more complex use cases, and Galaxy kind of allows
	# anything in the version field, so YMMV. It works with geerlingguy.* roles.
	- name: Use the ugliest hack in the world to find the highest version.
	set_fact:
	highest_role_version: >-
	{%- for version_data in role_versions | sort(attribute='name', reverse=True) -%}
	{%- if loop.first -%}
	{{ version_data.name }}
	{%- endif -%}
	{%- endfor -%}

It shouldn't even be necessary to sort the data; The versions: array is already sorted properly (i.e. the latest version is the first dictionary in the array).

I plan on creating a PR to address this issue and implement some other ideas I have to make the playbook more structurally sound. I will also take a stab at implementing #1.

I implemented a similar solution to find the latest version of a project on Github in one of my Ansible roles. [link]

Thank you again for all your great Ansible content! Watching/reading your educational content and just looking at your open-source Ansible code has been crucial to my Ansible journey.

-- Maxwell 😀