Skip to content

Commit f5ce653

Browse files
committed
removing deprecated junit methods used in tests
1 parent c0ea0aa commit f5ce653

File tree

5 files changed

+11
-9
lines changed

5 files changed

+11
-9
lines changed

src/test/java/com/flipkart/zjsonpatch/AbstractTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@
3030

3131
import static org.hamcrest.core.IsInstanceOf.instanceOf;
3232
import static org.hamcrest.core.StringContains.containsString;
33+
import static org.hamcrest.MatcherAssert.assertThat;
3334
import static org.junit.Assert.assertEquals;
34-
import static org.junit.Assert.assertThat;
3535
import static org.junit.Assert.fail;
3636

3737
@RunWith(Parameterized.class)

src/test/java/com/flipkart/zjsonpatch/ApiTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import java.util.EnumSet;
2626

2727
import static org.hamcrest.CoreMatchers.is;
28-
import static org.junit.Assert.assertThat;
28+
import static org.hamcrest.MatcherAssert.assertThat;
2929
import static org.junit.Assert.assertTrue;
3030

3131
/**
@@ -107,7 +107,7 @@ public void validatingAPatchWithAnInvalidOperationShouldThrowAnException() throw
107107
JsonPatch.validate(invalid);
108108
}
109109

110-
private static ObjectMapper objectMapper = new ObjectMapper();
110+
private static final ObjectMapper objectMapper = new ObjectMapper();
111111

112112
private static JsonNode readTree(String jsonString) throws IOException {
113113
return objectMapper.readTree(jsonString);

src/test/java/com/flipkart/zjsonpatch/CompatibilityTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626

2727
import static com.flipkart.zjsonpatch.CompatibilityFlags.*;
2828
import static org.hamcrest.core.IsEqual.equalTo;
29-
import static org.junit.Assert.assertThat;
29+
import static org.hamcrest.MatcherAssert.assertThat;
3030

3131
public class CompatibilityTest {
3232

src/test/java/com/flipkart/zjsonpatch/JsonDiffTest2.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,21 +26,24 @@
2626

2727
import java.io.IOException;
2828
import java.io.InputStream;
29+
import java.nio.charset.StandardCharsets;
2930

3031
import static org.hamcrest.core.IsEqual.equalTo;
32+
import static org.hamcrest.MatcherAssert.assertThat;
3133

3234
/**
3335
* @author ctranxuan (streamdata.io).
3436
*/
3537
public class JsonDiffTest2 {
36-
private static ObjectMapper objectMapper = new ObjectMapper();
38+
private static final ObjectMapper objectMapper = new ObjectMapper();
3739
private static ArrayNode jsonNode;
3840

3941
@BeforeClass
4042
public static void beforeClass() throws IOException {
4143
String path = "/testdata/diff.json";
4244
InputStream resourceAsStream = JsonDiffTest.class.getResourceAsStream(path);
43-
String testData = IOUtils.toString(resourceAsStream, "UTF-8");
45+
Assert.assertNotNull(resourceAsStream);
46+
String testData = IOUtils.toString(resourceAsStream, StandardCharsets.UTF_8);
4447
jsonNode = (ArrayNode) objectMapper.readTree(testData);
4548
}
4649

@@ -54,7 +57,7 @@ public void testPatchAppliedCleanly() {
5457

5558
JsonNode secondPrime = JsonPatch.apply(patch, first);
5659

57-
Assert.assertThat(message, secondPrime, equalTo(second));
60+
assertThat(message, secondPrime, equalTo(second));
5861
}
5962

6063
}

src/test/java/com/flipkart/zjsonpatch/MoveOperationTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@
2525
import java.util.Collection;
2626

2727
import static org.hamcrest.CoreMatchers.equalTo;
28-
import static org.junit.Assert.assertThat;
29-
28+
import static org.hamcrest.MatcherAssert.assertThat;
3029
/**
3130
* @author ctranxuan (streamdata.io).
3231
*/

0 commit comments

Comments
 (0)