address feedbacks

cherylEnkidu · cherylEnkidu · commit b1a487395d44 · 2025-07-24T13:30:16.000-04:00
diff --git a/.changeset/spotty-bananas-fry.md b/.changeset/spotty-bananas-fry.md
@@ -1,5 +1,5 @@
 ---
-'@firebase/firestore': major
+'@firebase/firestore': patch
 ---
 
 Fixed a bug where a rejected promise with an empty message in a transaction would cause a timeout. (https://github.com/firebase/firebase-js-sdk/issues/9147)
diff --git a/packages/firestore/src/core/transaction_runner.ts b/packages/firestore/src/core/transaction_runner.ts
@@ -112,7 +112,7 @@ export class TransactionRunner<T> {
     }
   }
 
-  private isRetryableTransactionError(error: Error): boolean {
+  private isRetryableTransactionError(error?: Error): boolean {
     if (error?.name === 'FirebaseError') {
       // In transactions, the backend will fail outdated reads with FAILED_PRECONDITION and
       // non-matching document versions with ABORTED. These errors should be retried.

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ export class TransactionRunner<T> {`
`112`	`112`	`}`
`113`	`113`	`}`
`114`	`114`
`115`		`- private isRetryableTransactionError(error: Error): boolean {`
	`115`	`+ private isRetryableTransactionError(error?: Error): boolean {`
`116`	`116`	`if (error?.name === 'FirebaseError') {`
`117`	`117`	`// In transactions, the backend will fail outdated reads with FAILED_PRECONDITION and`
`118`	`118`	`// non-matching document versions with ABORTED. These errors should be retried.`