Skip to content

Commit 62c20ce

Browse files
committed
EnumValueUnknownUnitTest.kt: enable unit test for EnumValue.Unknown.value, which is unblocked now that the data connect emulator binary has been upgraded to 2.10.1
1 parent 1966049 commit 62c20ce

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

firebase-dataconnect/connectors/src/test/kotlin/com/google/firebase/dataconnect/connectors/demo/EnumValueUnknownUnitTest.kt

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import com.google.firebase.dataconnect.testutil.property.arbitrary.dataConnect
2222
import com.google.firebase.dataconnect.testutil.property.arbitrary.distinctPair
2323
import io.kotest.assertions.withClue
2424
import io.kotest.common.ExperimentalKotest
25+
import io.kotest.matchers.nulls.shouldBeNull
2526
import io.kotest.matchers.shouldBe
2627
import io.kotest.matchers.shouldNotBe
2728
import io.kotest.matchers.types.shouldBeSameInstanceAs
@@ -32,7 +33,6 @@ import io.kotest.property.arbitrary.of
3233
import io.kotest.property.assume
3334
import io.kotest.property.checkAll
3435
import kotlinx.coroutines.test.runTest
35-
import org.junit.Ignore
3636
import org.junit.Test
3737

3838
@Suppress("ReplaceCallWithBinaryOperator")
@@ -47,16 +47,10 @@ class EnumValueUnknownUnitTest {
4747
}
4848

4949
@Test
50-
@Ignore(
51-
"TODO(cl/785477120) Enable this test once a data connect emulator build that " +
52-
"includes cl/785477120 is released, which will have a version >2.10.0 and " +
53-
"a firebase-tools version >14.11.0"
54-
)
5550
fun `value property should unconditionally be null`() = runTest {
5651
checkAll(propTestConfig, Arb.dataConnect.string()) { stringValue ->
5752
val enumValue = EnumValue.Unknown(stringValue)
58-
// TODO(cl/785477120) Uncomment the line below when the test is re-enabled.
59-
// enumValue.value.shouldBeNull()
53+
enumValue.value.shouldBeNull()
6054
}
6155
}
6256

0 commit comments

Comments
 (0)