Merge pull request #78 from fenix-hub/dev

*fixed:*  
- first login bug

Author: fenix-hub

README.md

@@ -1,5 +1,8 @@
-Check my **[Discord](https://discord.gg/KnJGY9S)** to stay updated on this repository.  
-*(Recommended since the AssetLibrary is not automatically updated)*  
+<p align="right">
+<a href="https://discord.gg/KnJGY9S">
+  <img src="https://github.com/fenix-hub/ColoredBadges/blob/master/svg/social/discord.svg" alt="react" style="vertical-align:top; margin:6px 4px">
+</a>
+</p>
 
 This plugin is now supported in [Godot Extended Library Discord](https://discord.gg/JNrcucg), check out the [Godot Extended Library Project](https://github.com/godot-extended-libraries)!
 
@@ -20,6 +23,13 @@ Godot Version: *3.2.3stable*
 Pushing and Pulling personal repositories while I'm working on Godot (especially if I'm under a GameJam) could take some time and force me to save the project, open the brwoser/git bash/git gui, and do all the stuff.  
 With this little addon which works directly in the editor, managing all your repositories will be very easy.  
 
+## What can it do?
+*Github Integration* offers the main functionalities provided by GitHub (and git itself), in a more accessible way.  
+Currenlty, you can:
+- Manage all of your public and private **repositories**, *including* the ones you share with organizations and the ones in which you are a collaborator (with proper permissions): create, delete, push and clone repositories within your Godot project
+- Manage all of your public and private **gists**: delete, edit and create gists with a functional text editor
+- Manage collaboration invitations, inviting user to your repositories or accept/decline invitations you have received
+
 ## How does it work?
 I'm currently working on a [Wiki](https://github.com/fenix-hub/godot-engine.github-integration/wiki) for this plugin. It is a process that will take some time to complete since I want to provide a well-organized wiki with some basic explanations about GitHub itself. Anyway, I'm working on a user-friendly plugin, so everything should be the very ease to use for GitHub experienced users, and a little intuitive for people who never used GitHub or are not so experienced.
 If you want to see some screenshots you can find them here `addons/github-integration/screenshots`
@@ -36,11 +46,7 @@ If you want to see some screenshots you can find them here `addons/github-integr
   </tr>
 </table>
 
-For my first donation I decided to add a SUPPORTERS.md file where there is a list of people who decided to financially support this plugin. I will never ask for anything in return for the free service I want to offer to  Godot's community, but it will always be an act of kindness that will encourage me to keep my plugins and projects updated.
-Here's the [Supporters List](./SUPPORTERS.md)
-
 ## :warning: Disclaimer  
-This addon was built for a **personal use** intention. It was released as an open source plugin in the hope that it could be useful to the Godot Engine Community.  
 As a "work in progress" project, there is *no warranty* for any eventual issue and bug that may broke your project.  
 I don't assume any responsibility for possible corruptions of your project. It is always advisable to keep a copy of your project and check any changes you make in your Github repository.  
 

addons/github-integration/plugin.cfg

@@ -3,5 +3,5 @@
 name="GitHub integration"
 description="Plugin to integrate GitHub requests directly via Godot Engine Editor"
 author="Nicolo (fenix) Santilio"
-version="1.3.2"
+version="1.3.4"
 script="scripts/github-integration.gd"

addons/github-integration/scripts/GitHub.gd

@@ -81,12 +81,10 @@ func _ready():
 	var connection = yield(RestHandler, "_check_connection")
 	match connection:
 		true:
-			SignIn.btnSignIn.set_disabled(false)
 			ConnectionIcon.set_texture(connection_status[2])
 			ConnectionIcon.set_tooltip("Connected to GitHub API")
 			RestartConnection.hide()
 		false:
-			SignIn.btnSignIn.set_disabled(true)
 			ConnectionIcon.set_texture(connection_status[1])
 			ConnectionIcon.set_tooltip("Can't connect to GitHub API, check your internet connection or API status")
 			RestartConnection.show()

addons/github-integration/scripts/Repo.gd

@@ -166,8 +166,9 @@ func open_repository(repository_item : RepositoryItem) -> void:
 
 	load_icons(repository)
 
-	load_collaborators(repository.collaborators.nodes as Array)
-	load_contributors(collaborators_login, repository.mentionableUsers.nodes as Array)
+	if repository.collaborators != null : 
+		load_collaborators(repository.collaborators.nodes as Array)
+		load_contributors(collaborators_login, repository.mentionableUsers.nodes as Array)
 
 	if branches.size():
 		default_branch_lbl.text = str(repository.defaultBranchRef.name)

addons/github-integration/scripts/SignIn.gd

@@ -24,7 +24,12 @@ var logfile : bool = false
 
 onready var Client : HTTPClient = HTTPClient.new()
 
+var userdata : bool = false
+
 func connect_signals() -> void:
+	Mail.connect("text_changed", self, "_on_mail_changed")
+	Token.connect("text_changed", self, "_on_token_changed")
+	
 	btnSignIn.connect("pressed",self,"sign_in")
 	btnCreateToken.connect("pressed",self,"create_token")
 
@@ -41,16 +46,26 @@ func _ready() -> void:
 	connect_signals()
 	LogfileIcon.hide()
 	Error.hide()
-
-	btnSignIn.set_disabled(true)
+	
 	DeleteDataBtn.set_disabled(true)
 
+	yield(get_tree(),"idle_frame")
+	check_user()
+
+func _on_userdata_ready():
+	userdata = true
+
+func check_user():
 	if UserData.user_exists():
 		logfile = true
 		LogfileIcon.show()
 		DeleteDataBtn.disabled = false
 		Mail.text = "<logfile.mail>"
+		_on_mail_changed(Mail.text)
 		Token.text = "<logfile.password>"
+		_on_token_changed(Token.text)
+		get_parent().print_debug_message("user data found, just sign in without using your credentials.")
+		btnSignIn.set_disabled(false)
 
 func set_darkmode(darkmode : bool) -> void:
 	if darkmode:
@@ -131,3 +146,11 @@ func delete_user():
 
 func close_popup() :
 	DeleteHover.hide()
+
+func _on_mail_changed(text : String):
+	if not text in [""," "] and not Token.text in [""," "]: btnSignIn.set_disabled(false)
+	else: if not logfile: btnSignIn.set_disabled(true)
+
+func _on_token_changed(text : String):
+	if not text in [""," "] and not Mail.text in [""," "]: btnSignIn.set_disabled(false)
+	else: if not logfile: btnSignIn.set_disabled(true)

addons/github-integration/scripts/user_data.gd

@@ -39,6 +39,7 @@ var gitlfs_request : String = ".git/info/lfs/objects/batch"
 var plugin_version : String = "0.9.4"
 
 func _ready():
+	PluginSettings._check_plugin_path()
 	directory = PluginSettings.plugin_path
 
 func user_exists():