Skip to content

Commit 1da8fac

Browse files
authored
Merge pull request #81 from fenix-hub/dev
Update v1.3.6
2 parents b37c854 + 709d49d commit 1da8fac

File tree

5 files changed

+12
-5
lines changed

5 files changed

+12
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ This plugin is now supported in [Godot Extended Library Discord](https://discord
1212
A complete GitHub integration for your Godot Editor! Manage your project without even opening your browser.
1313

1414
Author: *"Nicolo (fenix) Santilio"*
15-
Version: *1.3.5*
15+
Version: *1.3.6*
1616
Wiki: *[supported](https://github.com/fenix-hub/godot-engine.github-integration/wiki)*
1717
Godot Version: *3.2.3stable*
1818

1919
<img align="center" src="addons/github-integration/screenshots/banner.png">
2020

2121
## What is this?
2222
*GitHub Integration* is a addon for Godot Engine that I've created mainly for a personal purpose.
23-
Pushing and Pulling personal repositories while I'm working on Godot (especially if I'm under a GameJam) could take some time and force me to save the project, open the brwoser/git bash/git gui, and do all the stuff.
23+
Pushing and Pulling repositories while I'm working on Godot (especially if I'm under a GameJam) could take some time and force me to save the project, open the brwoser/git bash/git gui, and do all the stuff.
2424
With this little addon which works directly in the editor, managing all your repositories will be very easy.
2525

2626
## What can it do?

addons/github-integration/plugin.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
name="GitHub integration"
44
description="Plugin to integrate GitHub requests directly via Godot Engine Editor"
55
author="Nicolo (fenix) Santilio"
6-
version="1.3.4"
6+
version="1.3.6"
77
script="scripts/github-integration.gd"

addons/github-integration/scripts/Commit.gd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ func connect_signals():
116116
func request_completed(result, response_code, headers, body ):
117117
get_parent().print_debug_message("REQUEST TO API : Request exited with code %s" % response_code)
118118
if response_code == 422:
119-
get_parent().print_debug_message(JSON.parse(body.get_string_from_utf8()).result)
119+
get_parent().print_debug_message(str(JSON.parse(body.get_string_from_utf8()).result))
120120
if result == 0:
121121
match requesting:
122122
REQUESTS.UPLOAD:

addons/github-integration/scripts/ContributorClass.gd

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ onready var login_lbl : Label = $Login
77
onready var name_lbl : Label = $Name
88
onready var client : HTTPRequest = $HTTPRequest
99

10+
var is_downloading : bool = false
11+
1012
var _avatar : String
1113
var _name : String
1214
var _login : String
@@ -32,6 +34,10 @@ func set_contributor_name(n : String) -> void:
3234
func set_contributor_avatar(a : String) -> void:
3335
_avatar = a
3436
client.request(_avatar)
37+
is_downloading = true
38+
39+
func _process(delta):
40+
if is_downloading: print(client.get_downloaded_bytes()/client.get_body_size()*100, " %")
3541

3642
func _on_request_completed(result: int, response_code: int, headers: PoolStringArray, avatar: PoolByteArray) -> void:
3743
if result == 0:
@@ -46,3 +52,4 @@ func _on_request_completed(result: int, response_code: int, headers: PoolStringA
4652
var texture : ImageTexture = ImageTexture.new()
4753
texture.create_from_image(image)
4854
avatar_texture.set_texture(texture)
55+
is_downloading = false

addons/github-integration/scripts/PluginSettings.gd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ func _check_plugin_path():
1717
var dir = Directory.new()
1818
if not dir.dir_exists(plugin_path):
1919
dir.make_dir(plugin_path)
20-
if PluginSettings.debug:
20+
if debug:
2121
printerr("[GitHub Integration] >> ","made custom directory in user folder, it is placed at ", plugin_path)
2222

2323
func _ready():

0 commit comments

Comments
 (0)