refactor: remove unused function & early return

Author: LouisHaftmann

lib/db/index.ts

@@ -244,18 +244,3 @@ export async function uploadExists(db: DB, { key, version }: { key: string; vers
     .executeTakeFirst()
   return !!row
 }
-
-export async function upsertVersion(db: DB, version: string) {
-  const existing = await db
-    .selectFrom('meta')
-    .where('key', '=', 'version')
-    .select('value')
-    .executeTakeFirst()
-  if (existing) {
-    await db.updateTable('meta').set('value', version).where('key', '=', 'version').execute()
-  } else {
-    await db.insertInto('meta').values({ key: 'version', value: version }).execute()
-  }
-
-  return version !== existing?.value
-}

plugins/setup.ts

@@ -6,7 +6,8 @@ import { logger } from '~/lib/logger'
 import { initializeStorage, useStorageAdapter } from '~/lib/storage'
 
 export default defineNitroPlugin(async (nitro) => {
-  logger.info(`🚀 Starting GitHub Actions Cache Server (${useRuntimeConfig().version})`)
+  const version = useRuntimeConfig().version
+  logger.info(`🚀 Starting GitHub Actions Cache Server (${version})`)
 
   await initializeDatabase()
   await initializeStorage()
@@ -34,29 +35,26 @@ export default defineNitroPlugin(async (nitro) => {
     })
   }
 
-  const version = useRuntimeConfig().version
-  if (version) {
-    const db = useDB()
-    const existing = await db
-      .selectFrom('meta')
-      .where('key', '=', 'version')
-      .select('value')
-      .executeTakeFirst()
+  if (!version) throw new Error('No version found in runtime config')
 
-    if (!existing || existing.value !== version) {
-      logger.info(
-        `Version changed from ${existing?.value ?? '[no version, first install]'} to ${version}. Pruning cache...`,
-      )
-      await useStorageAdapter().pruneCaches()
-    }
+  const db = useDB()
+  const existing = await db
+    .selectFrom('meta')
+    .where('key', '=', 'version')
+    .select('value')
+    .executeTakeFirst()
 
-    if (existing) {
-      await db.updateTable('meta').set('value', version).where('key', '=', 'version').execute()
-    } else {
-      await db.insertInto('meta').values({ key: 'version', value: version }).execute()
-    }
+  if (!existing || existing.value !== version) {
+    logger.info(
+      `Version changed from ${existing?.value ?? '[no version, first install]'} to ${version}. Pruning cache...`,
+    )
+    await useStorageAdapter().pruneCaches()
+  }
+
+  if (existing) {
+    await db.updateTable('meta').set('value', version).where('key', '=', 'version').execute()
   } else {
-    logger.warn('No version found in runtime config')
+    await db.insertInto('meta').values({ key: 'version', value: version }).execute()
   }
 
   if (process.send) process.send('nitro:ready')