Skip to content

Commit e812651

Browse files
committed
Block: Connect template_editor modified signal automatically
1 parent a14eed5 commit e812651

File tree

5 files changed

+6
-8
lines changed

5 files changed

+6
-8
lines changed

addons/block_code/ui/blocks/block/block.gd

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,12 @@ func _update_template_editor():
6060

6161
template_editor.format_string = definition.display_template if definition else ""
6262
template_editor.parameter_defaults = definition.get_defaults_for_node(_context.parent_node) if definition else {}
63+
if not template_editor.modified.is_connected(_on_template_editor_modified):
64+
template_editor.modified.connect(_on_template_editor_modified)
65+
66+
67+
func _on_template_editor_modified():
68+
modified.emit()
6369

6470

6571
func _gui_input(event):
@@ -84,10 +90,6 @@ func _gui_input(event):
8490
EditorInterface.popup_dialog_centered(dialog)
8591

8692

87-
func _modified():
88-
modified.emit()
89-
90-
9193
func remove_from_tree():
9294
var parent = get_parent()
9395
if parent:

addons/block_code/ui/blocks/control_block/control_block.tscn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,5 +95,4 @@ shift_top = 20.0
9595
[node name="SnapPoint" parent="VBoxContainer" instance=ExtResource("3_nhryi")]
9696
layout_mode = 2
9797

98-
[connection signal="modified" from="." to="." method="_modified"]
9998
[connection signal="mouse_down" from="VBoxContainer/MarginContainer/Rows/Row/DragDropArea" to="." method="_on_drag_drop_area_mouse_down"]

addons/block_code/ui/blocks/entry_block/entry_block.tscn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,4 +56,3 @@ layout_mode = 2
5656
layout_mode = 2
5757

5858
[connection signal="mouse_down" from="VBoxContainer/TopMarginContainer/DragDropArea" to="." method="_on_drag_drop_area_mouse_down"]
59-
[connection signal="modified" from="VBoxContainer/TopMarginContainer/MarginContainer/TemplateEditor" to="." method="_modified"]

addons/block_code/ui/blocks/parameter_block/parameter_block.tscn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,3 @@ theme_override_constants/margin_bottom = 8
4848
[connection signal="focus_entered" from="." to="." method="_on_focus_entered"]
4949
[connection signal="focus_exited" from="." to="." method="_on_focus_exited"]
5050
[connection signal="mouse_down" from="DragDropArea" to="." method="_on_drag_drop_area_mouse_down"]
51-
[connection signal="modified" from="MarginContainer/TemplateEditor" to="." method="_modified"]

addons/block_code/ui/blocks/statement_block/statement_block.tscn

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,4 +55,3 @@ layout_mode = 2
5555
layout_mode = 2
5656

5757
[connection signal="mouse_down" from="VBoxContainer/TopMarginContainer/DragDropArea" to="." method="_on_drag_drop_area_mouse_down"]
58-
[connection signal="modified" from="VBoxContainer/TopMarginContainer/MarginContainer/TemplateEditor" to="." method="_modified"]

0 commit comments

Comments
 (0)