Skip to content

Commit f4088b1

Browse files
committed
refactor: use otel-kotlin
1 parent f6853d9 commit f4088b1

File tree

19 files changed

+112
-660
lines changed

19 files changed

+112
-660
lines changed

embrace-android-otel/src/main/kotlin/io/embrace/android/embracesdk/internal/otel/impl/EmbOpenTelemetry.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@ import io.embrace.opentelemetry.kotlin.tracing.TracerProvider
1111
@OptIn(ExperimentalApi::class)
1212
class EmbOpenTelemetry(
1313
private val impl: OpenTelemetry,
14-
override val clock: Clock,
1514
traceProviderSupplier: () -> TracerProvider,
1615
) : OpenTelemetry by impl {
17-
16+
override val clock: Clock = impl.clock
1817
override val tracerProvider: TracerProvider = traceProviderSupplier()
1918
}

embrace-android-otel/src/main/kotlin/io/embrace/android/embracesdk/internal/otel/impl/EmbOtelJavaOpenTelemetry.kt

Lines changed: 0 additions & 17 deletions
This file was deleted.

embrace-android-otel/src/main/kotlin/io/embrace/android/embracesdk/internal/otel/impl/EmbOtelJavaSpan.kt

Lines changed: 0 additions & 79 deletions
This file was deleted.

embrace-android-otel/src/main/kotlin/io/embrace/android/embracesdk/internal/otel/impl/EmbOtelJavaSpanBuilder.kt

Lines changed: 0 additions & 75 deletions
This file was deleted.

embrace-android-otel/src/main/kotlin/io/embrace/android/embracesdk/internal/otel/impl/EmbOtelJavaTracer.kt

Lines changed: 0 additions & 33 deletions
This file was deleted.

embrace-android-otel/src/main/kotlin/io/embrace/android/embracesdk/internal/otel/impl/EmbOtelJavaTracerBuilder.kt

Lines changed: 0 additions & 25 deletions
This file was deleted.

embrace-android-otel/src/main/kotlin/io/embrace/android/embracesdk/internal/otel/impl/EmbOtelJavaTracerProvider.kt

Lines changed: 0 additions & 59 deletions
This file was deleted.

embrace-android-otel/src/main/kotlin/io/embrace/android/embracesdk/internal/otel/impl/EmbSpan.kt

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
package io.embrace.android.embracesdk.internal.otel.impl
22

3+
import io.embrace.android.embracesdk.internal.clock.nanosToMillis
34
import io.embrace.android.embracesdk.internal.otel.spans.EmbraceSdkSpan
45
import io.embrace.android.embracesdk.internal.otel.toOtelKotlin
56
import io.embrace.android.embracesdk.internal.payload.Attribute
6-
import io.embrace.android.embracesdk.internal.payload.Span.Status
77
import io.embrace.opentelemetry.kotlin.Clock
88
import io.embrace.opentelemetry.kotlin.ExperimentalApi
99
import io.embrace.opentelemetry.kotlin.aliases.OtelJavaSpanContext
@@ -64,7 +64,7 @@ class EmbSpan(
6464

6565
override fun end(timestamp: Long) {
6666
if (isRecording()) {
67-
impl.stop(endTimeMs = timestamp)
67+
impl.stop(endTimeMs = timestamp.nanosToMillis())
6868
}
6969
}
7070

@@ -103,9 +103,11 @@ class EmbSpan(
103103
get() = impl.getStartTimeMs() ?: 0
104104

105105
override var status: StatusCode
106-
get() = impl.status.toOtelKotlin()
106+
get() = impl.status
107107
set(value) {
108-
impl.setStatus(value)
108+
if (isRecording()) {
109+
impl.status = value
110+
}
109111
}
110112

111113
override fun events(): List<SpanEvent> = impl.events().map {
@@ -145,10 +147,4 @@ class EmbSpan(
145147
OtelJavaTraceState.getDefault()
146148
).toOtelKotlin()
147149
}
148-
149-
private fun Status.toOtelKotlin() = when (this) {
150-
Status.UNSET -> StatusCode.Unset
151-
Status.ERROR -> StatusCode.Error(null)
152-
Status.OK -> StatusCode.Ok
153-
}
154150
}

embrace-android-otel/src/main/kotlin/io/embrace/android/embracesdk/internal/otel/sdk/OtelSdkWrapper.kt

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import io.embrace.android.embracesdk.internal.otel.config.OtelSdkConfig
66
import io.embrace.android.embracesdk.internal.otel.config.getMaxTotalAttributeCount
77
import io.embrace.android.embracesdk.internal.otel.config.getMaxTotalEventCount
88
import io.embrace.android.embracesdk.internal.otel.config.getMaxTotalLinkCount
9-
import io.embrace.android.embracesdk.internal.otel.impl.EmbOtelJavaOpenTelemetry
10-
import io.embrace.android.embracesdk.internal.otel.impl.EmbOtelJavaTracerProvider
9+
import io.embrace.android.embracesdk.internal.otel.impl.EmbOpenTelemetry
10+
import io.embrace.android.embracesdk.internal.otel.impl.EmbTracerProvider
1111
import io.embrace.android.embracesdk.internal.otel.logs.DefaultLogRecordProcessor
1212
import io.embrace.android.embracesdk.internal.otel.spans.DefaultSpanProcessor
1313
import io.embrace.android.embracesdk.internal.otel.spans.SpanService
@@ -17,7 +17,7 @@ import io.embrace.opentelemetry.kotlin.ExperimentalApi
1717
import io.embrace.opentelemetry.kotlin.OpenTelemetry
1818
import io.embrace.opentelemetry.kotlin.OpenTelemetryInstance
1919
import io.embrace.opentelemetry.kotlin.aliases.OtelJavaOpenTelemetry
20-
import io.embrace.opentelemetry.kotlin.aliases.OtelJavaTracerProvider
20+
import io.embrace.opentelemetry.kotlin.compatWithOtelKotlin
2121
import io.embrace.opentelemetry.kotlin.kotlinApi
2222
import io.embrace.opentelemetry.kotlin.logging.Logger
2323
import io.embrace.opentelemetry.kotlin.tracing.Tracer
@@ -88,16 +88,10 @@ class OtelSdkWrapper(
8888
}
8989

9090
val openTelemetryJava: OtelJavaOpenTelemetry by lazy {
91-
EmbOtelJavaOpenTelemetry(
92-
traceProviderSupplier = { externalTracerProvider }
93-
)
94-
}
95-
96-
private val externalTracerProvider: OtelJavaTracerProvider by lazy {
97-
EmbOtelJavaTracerProvider(
98-
sdkTracerProvider = kotlinApi.tracerProvider,
99-
spanService = spanService,
100-
clock = otelClock,
91+
OpenTelemetryInstance.compatWithOtelKotlin(
92+
EmbOpenTelemetry(kotlinApi) {
93+
EmbTracerProvider(kotlinApi.tracerProvider, spanService, otelClock)
94+
}
10195
)
10296
}
10397
}

0 commit comments

Comments
 (0)