refactor: switch otel java implementation to wrap kotlin api

Author: fractalwrench

embrace-android-core/src/main/kotlin/io/embrace/android/embracesdk/internal/injection/OpenTelemetryModuleImpl.kt

@@ -61,8 +61,7 @@ internal class OpenTelemetryModuleImpl(
             try {
                 OtelSdkWrapper(
                     otelClock = openTelemetryClock,
-                    configuration = otelSdkConfig,
-                    spanService = spanService
+                    configuration = otelSdkConfig
                 )
             } catch (exc: NoClassDefFoundError) {
                 throw LinkageError(

embrace-android-otel/src/main/kotlin/io/embrace/android/embracesdk/internal/otel/impl/EmbOpenTelemetry.kt

@@ -11,9 +11,8 @@ import io.embrace.opentelemetry.kotlin.tracing.TracerProvider
 @OptIn(ExperimentalApi::class)
 class EmbOpenTelemetry(
     private val impl: OpenTelemetry,
-    override val clock: Clock,
     traceProviderSupplier: () -> TracerProvider,
 ) : OpenTelemetry by impl {
-
+    override val clock: Clock = impl.clock
     override val tracerProvider: TracerProvider = traceProviderSupplier()
 }

embrace-android-otel/src/main/kotlin/io/embrace/android/embracesdk/internal/otel/impl/EmbOtelJavaOpenTelemetry.kt

@@ -1,5 +1,6 @@
 package io.embrace.android.embracesdk.internal.otel.impl
 
+import io.embrace.android.embracesdk.internal.clock.nanosToMillis
 import io.embrace.android.embracesdk.internal.otel.spans.EmbraceSdkSpan
 import io.embrace.android.embracesdk.internal.otel.toOtelKotlin
 import io.embrace.android.embracesdk.internal.payload.Attribute
@@ -57,7 +58,7 @@ class EmbSpan(
         setStringAttribute(key, value.toString())
     }
 
-    override fun end(): Unit = end(timestamp = clock.now())
+    override fun end(): Unit = end(timestamp = clock.now().nanosToMillis())
 
     override fun end(timestamp: Long) {
         if (isRecording()) {
@@ -102,7 +103,9 @@ class EmbSpan(
     override var status: StatusCode
         get() = impl.status.toOtelKotlin()
         set(value) {
-            impl.setStatus(value)
+            if (isRecording()) {
+                impl.setStatus(value)
+            }
         }
 
     override fun events(): List<SpanEvent> = impl.events().map {