Skip to content

Minor changes in Getting Started Section #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Minor changes in Getting Started Section #1098

wants to merge 6 commits into from

Conversation

emiliocuestaf
Copy link
Contributor

@emiliocuestaf emiliocuestaf commented Jul 17, 2025 •
edited by Javgilavi
Loading

Description

  • Removed duplicated cmake/make instructions in Python getting started example
  • Added reminder to include the binding libs in LD_LIBRARY_PATH
  • DDS_Domain.svg image showed DataReaders reading multiple topics and DataWriter writing multiple Topics. New image updated correctly displaying a 1to1 relation

Contributor Checklist

  • Commit messages follow the project guidelines.
  • [NO] Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • [ NO] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@emiliocuestaf
Removed duplicated cmake command and added reminder of updating LD_LI…
b41c3c6 
…BRARY_PATH in the getting started Python example

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf
Updating DDS Domain image to make (writer_or_reader)-topic relation 1…
890462a 
… to 1

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf
Image from previous commit was too small
c443622 
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf emiliocuestaf requested a review from Javgilavi July 17, 2025 10:06
Javgilavi
Javgilavi reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@Javgilavi Javgilavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes.

Also, why now the dds_domain.svg is brown and with other colors?
I think is not as visible as the original colors

@emiliocuestaf @Javgilavi
Update docs/fastdds/getting_started/simple_python_app/includes/dataTy…
e7dd48d 
…pe.rst

Co-authored-by: Javier Gil Avilés <javiergil@eprosima.com>
Signed-off-by: Emilio Cuesta Fernandez <emiliocuesta@eprosima.com>
@emiliocuestaf emiliocuestaf requested a review from Javgilavi July 17, 2025 10:56
@emiliocuestaf
Splitting longer lines as requested by CI
0f00570 
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@Javgilavi Javgilavi self-requested a review July 17, 2025 12:26
@emiliocuestaf
minor fix to pass spell tests
5b0215a 
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf emiliocuestaf marked this pull request as ready for review July 17, 2025 15:20
@Javgilavi Javgilavi requested review from Javgilavi and removed request for Javgilavi July 18, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Javgilavi Javgilavi Awaiting requested review from Javgilavi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emiliocuestaf @Javgilavi