Skip to content

Commit c411843

Browse files
committed
Update some TODO comments
1 parent 7dbde06 commit c411843

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

command-line-parser.dylan

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ copyright: See LICENSE file in this distribution.
66
//======================================================================
77
// The All-Singing, All-Dancing Argument Parser
88
//======================================================================
9+
//
910
// Ole J. Tetlie wrote an option parser, and it was pretty good. But it
1011
// didn't support all the option types required by d2c, and besides, we
1112
// felt a need to overdo something.
@@ -29,20 +30,12 @@ copyright: See LICENSE file in this distribution.
2930
// All the tokens on that command line are arguments. "-x" and "--y"
3031
// are options, and "bar" is a parameter. "baz" is a positional argument.
3132

32-
// todo -- There is no indication of default values in the generated synopsis,
33-
// and the syntax for specifying "syntax" and docstring is bizarre at
34-
// best. --cgay 2006.11.27
35-
3633
// TODO(cgay): <choice-option>: --foo=a|b|c (#f as choice means option
3734
// value is optional?)
3835

3936
// TODO(cgay): Add a required: (or required?: ?) init keyword that
4037
// makes non-positional args required else an error is generated.
4138

42-
// TODO(cgay): This error sucks: "<unknown-option>" is not present as
43-
// a key for {<string-table>: size 12}. How about "<unknown-option>
44-
// is not a recognized command-line option." See next item.
45-
4639
// TODO(cgay): With an option that has negative options (e.g.,
4740
// --verbose and --quiet in the same option) just show the positive
4841
// option in the synopsis but add a comment to the doc about the

help.dylan

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ Module: command-line-parser
22
Synopsis: Implements the --help flag and help subcommand
33

44

5+
// TODO(cgay): Automatically display option default values. It's too easy to
6+
// forget to add %default% to the help string.
7+
58
// TODO(cgay): Wrap the descriptions nicely
69

710
define function program-name () => (name :: <string>)

0 commit comments

Comments
 (0)