Skip to content

Commit 3db69f0

Browse files
authored
Replace the copy-pastes of TargetJvmEnvironment (#2561)
* Remove the workaround for Guava issue 6801 * Revert "Remove the workaround for Guava issue 6801" This reverts commit 131829e. * It's still required
1 parent 8d4cd28 commit 3db69f0

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

plugin-gradle/src/main/java/com/diffplug/gradle/spotless/GradleProvisioner.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2016-2024 DiffPlug
2+
* Copyright 2016-2025 DiffPlug
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -26,9 +26,9 @@
2626
import org.gradle.api.artifacts.Configuration;
2727
import org.gradle.api.artifacts.ConfigurationContainer;
2828
import org.gradle.api.artifacts.dsl.DependencyHandler;
29-
import org.gradle.api.attributes.Attribute;
3029
import org.gradle.api.attributes.Bundling;
3130
import org.gradle.api.attributes.Category;
31+
import org.gradle.api.attributes.java.TargetJvmEnvironment;
3232
import org.gradle.api.initialization.dsl.ScriptHandler;
3333
import org.slf4j.Logger;
3434
import org.slf4j.LoggerFactory;
@@ -125,9 +125,8 @@ private static Provisioner forConfigurationContainer(Project project, Configurat
125125
config.attributes(attr -> {
126126
attr.attribute(Category.CATEGORY_ATTRIBUTE, project.getObjects().named(Category.class, Category.LIBRARY));
127127
attr.attribute(Bundling.BUNDLING_ATTRIBUTE, project.getObjects().named(Bundling.class, Bundling.EXTERNAL));
128-
// TODO: This is a copy-paste from org.gradle.api.attributes.java.TargetJvmEnvironment which is added in Gradle 7.0, remove this once we drop support for Gradle 6.x.
129128
// Add this attribute for resolving Guava dependency, see https://github.com/google/guava/issues/6801.
130-
attr.attribute(Attribute.of("org.gradle.jvm.environment", String.class), "standard-jvm");
129+
attr.attribute(TargetJvmEnvironment.TARGET_JVM_ENVIRONMENT_ATTRIBUTE, project.getObjects().named(TargetJvmEnvironment.class, TargetJvmEnvironment.STANDARD_JVM));
131130
});
132131
return config.resolve();
133132
} catch (Exception e) {

testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@
3131
import org.gradle.api.artifacts.Dependency;
3232
import org.gradle.api.artifacts.ResolveException;
3333
import org.gradle.api.artifacts.dsl.RepositoryHandler;
34-
import org.gradle.api.attributes.Attribute;
3534
import org.gradle.api.attributes.Bundling;
3635
import org.gradle.api.attributes.Category;
36+
import org.gradle.api.attributes.java.TargetJvmEnvironment;
3737
import org.gradle.testfixtures.ProjectBuilder;
3838

3939
import com.diffplug.common.base.Errors;
@@ -74,9 +74,8 @@ private static Provisioner createWithRepositories(Consumer<RepositoryHandler> re
7474
config.attributes(attr -> {
7575
attr.attribute(Category.CATEGORY_ATTRIBUTE, project.getObjects().named(Category.class, Category.LIBRARY));
7676
attr.attribute(Bundling.BUNDLING_ATTRIBUTE, project.getObjects().named(Bundling.class, Bundling.EXTERNAL));
77-
// TODO: This is a copy-paste from org.gradle.api.attributes.java.TargetJvmEnvironment which is added in Gradle 7.0, remove this once we drop support for Gradle 6.x.
7877
// Add this attribute for resolving Guava dependency, see https://github.com/google/guava/issues/6801.
79-
attr.attribute(Attribute.of("org.gradle.jvm.environment", String.class), "standard-jvm");
78+
attr.attribute(TargetJvmEnvironment.TARGET_JVM_ENVIRONMENT_ATTRIBUTE, project.getObjects().named(TargetJvmEnvironment.class, TargetJvmEnvironment.STANDARD_JVM));
8079
});
8180
try {
8281
return config.resolve();

0 commit comments

Comments
 (0)