feat(config): add APY portfolio feature flag (#7054)

# Motivation

New information will be shown in the Portfolio page regarding APY, and
we want to be able to hide/show it behind a ff.

[NNS1-3922](https://dfinity.atlassian.net/browse/NNS1-3922)

# Changes

- Add `ENABLE_APY_PORTFOLIO` flag.
- Run `scripts/nns-dapp/test-config --update` to update config files.

# Tests

- Should pass as before.

# Todos

- [x] Accessibility (a11y) – any impact?
- [x] Changelog – is it needed?


[NNS1-3922]:
https://dfinity.atlassian.net/browse/NNS1-3922?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Author: yhabib

config.json

@@ -101,7 +101,8 @@
           "ENABLE_DISBURSE_MATURITY": true,
           "ENABLE_SNS_TOPICS": true,
           "ENABLE_NNS_TOPICS": false,
-          "ENABLE_LAUNCHPAD_REDESIGN": false
+          "ENABLE_LAUNCHPAD_REDESIGN": false,
+          "ENABLE_APY_PORTFOLIO": false
         }
       }
     },

frontend/src/lib/constants/environment.constants.ts

@@ -23,6 +23,7 @@ export interface FeatureFlags<T> {
   ENABLE_SNS_TOPICS: T;
   ENABLE_NNS_TOPICS: T;
   ENABLE_LAUNCHPAD_REDESIGN: T;
+  ENABLE_APY_PORTFOLIO: T;
 }
 export const defaultFeatureFlagValues: FeatureFlags<boolean> = {
   ENABLE_CKTESTBTC: false,
@@ -33,6 +34,7 @@ export const defaultFeatureFlagValues: FeatureFlags<boolean> = {
   ENABLE_SNS_TOPICS: false,
   ENABLE_NNS_TOPICS: false,
   ENABLE_LAUNCHPAD_REDESIGN: false,
+  ENABLE_APY_PORTFOLIO: false,
 };
 
 export type FeatureKey = keyof FeatureFlags<boolean>;

frontend/src/lib/stores/feature-flags.store.ts

@@ -157,4 +157,5 @@ export const {
   ENABLE_SNS_TOPICS,
   ENABLE_NNS_TOPICS,
   ENABLE_LAUNCHPAD_REDESIGN,
+  ENABLE_APY_PORTFOLIO,
 } = featureFlagsStore;

frontend/vitest.setup.ts

@@ -151,6 +151,7 @@ vi.mock("./src/lib/utils/env-vars.utils.ts", () => ({
       ENABLE_SNS_TOPICS: false,
       ENABLE_NNS_TOPICS: false,
       ENABLE_LAUNCHPAD_REDESIGN: false,
+      ENABLE_APY_PORTFOLIO: false,
     }),
     fetchRootKey: "false",
     host: "https://icp-api.io",

scripts/nns-dapp/test-config-assets/app/arg.did

@@ -10,7 +10,7 @@
     record{ 0="CKUSDC_LEDGER_CANISTER_ID"; 1="xevnm-gaaaa-aaaar-qafnq-cai" };
     record{ 0="CYCLES_MINTING_CANISTER_ID"; 1="rkp4c-7iaaa-aaaaa-aaaca-cai" };
     record{ 0="DFX_NETWORK"; 1="app" };
-    record{ 0="FEATURE_FLAGS"; 1="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_CKTESTBTC\":false,\"ENABLE_DISBURSE_MATURITY\":true,\"ENABLE_LAUNCHPAD_REDESIGN\":false,\"ENABLE_NNS_TOPICS\":false,\"ENABLE_SNS_TOPICS\":true}" };
+    record{ 0="FEATURE_FLAGS"; 1="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_APY_PORTFOLIO\":false,\"ENABLE_CKTESTBTC\":false,\"ENABLE_DISBURSE_MATURITY\":true,\"ENABLE_LAUNCHPAD_REDESIGN\":false,\"ENABLE_NNS_TOPICS\":false,\"ENABLE_SNS_TOPICS\":true}" };
     record{ 0="FETCH_ROOT_KEY"; 1="false" };
     record{ 0="GOVERNANCE_CANISTER_ID"; 1="rrkah-fqaaa-aaaaa-aaaaq-cai" };
     record{ 0="HOST"; 1="https://icp-api.io" };

scripts/nns-dapp/test-config-assets/app/env

@@ -7,7 +7,7 @@ VITE_LEDGER_CANISTER_ID=ryjl3-tyaaa-aaaaa-aaaba-cai
 VITE_INDEX_CANISTER_ID=qhbym-qaaaa-aaaaa-aaafq-cai
 VITE_OWN_CANISTER_ID=xnjld-hqaaa-aaaal-qb56q-cai
 VITE_FETCH_ROOT_KEY=false
-VITE_FEATURE_FLAGS="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_CKTESTBTC\":false,\"ENABLE_DISBURSE_MATURITY\":true,\"ENABLE_LAUNCHPAD_REDESIGN\":false,\"ENABLE_NNS_TOPICS\":false,\"ENABLE_SNS_TOPICS\":true}"
+VITE_FEATURE_FLAGS="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_APY_PORTFOLIO\":false,\"ENABLE_CKTESTBTC\":false,\"ENABLE_DISBURSE_MATURITY\":true,\"ENABLE_LAUNCHPAD_REDESIGN\":false,\"ENABLE_NNS_TOPICS\":false,\"ENABLE_SNS_TOPICS\":true}"
 VITE_HOST=https://icp-api.io
 VITE_IDENTITY_SERVICE_URL=https://identity.internetcomputer.org/
 VITE_ICP_SWAP_URL=https://uvevg-iyaaa-aaaak-ac27q-cai.raw.ic0.app/

scripts/nns-dapp/test-config-assets/mainnet/arg.did

@@ -10,7 +10,7 @@
     record{ 0="CKUSDC_LEDGER_CANISTER_ID"; 1="xevnm-gaaaa-aaaar-qafnq-cai" };
     record{ 0="CYCLES_MINTING_CANISTER_ID"; 1="rkp4c-7iaaa-aaaaa-aaaca-cai" };
     record{ 0="DFX_NETWORK"; 1="mainnet" };
-    record{ 0="FEATURE_FLAGS"; 1="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_CKTESTBTC\":false,\"ENABLE_DISBURSE_MATURITY\":true,\"ENABLE_LAUNCHPAD_REDESIGN\":false,\"ENABLE_NNS_TOPICS\":false,\"ENABLE_SNS_TOPICS\":true}" };
+    record{ 0="FEATURE_FLAGS"; 1="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_APY_PORTFOLIO\":false,\"ENABLE_CKTESTBTC\":false,\"ENABLE_DISBURSE_MATURITY\":true,\"ENABLE_LAUNCHPAD_REDESIGN\":false,\"ENABLE_NNS_TOPICS\":false,\"ENABLE_SNS_TOPICS\":true}" };
     record{ 0="FETCH_ROOT_KEY"; 1="false" };
     record{ 0="GOVERNANCE_CANISTER_ID"; 1="rrkah-fqaaa-aaaaa-aaaaq-cai" };
     record{ 0="HOST"; 1="https://icp-api.io" };

scripts/nns-dapp/test-config-assets/mainnet/env

@@ -7,7 +7,7 @@ VITE_LEDGER_CANISTER_ID=ryjl3-tyaaa-aaaaa-aaaba-cai
 VITE_INDEX_CANISTER_ID=qhbym-qaaaa-aaaaa-aaafq-cai
 VITE_OWN_CANISTER_ID=qoctq-giaaa-aaaaa-aaaea-cai
 VITE_FETCH_ROOT_KEY=false
-VITE_FEATURE_FLAGS="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_CKTESTBTC\":false,\"ENABLE_DISBURSE_MATURITY\":true,\"ENABLE_LAUNCHPAD_REDESIGN\":false,\"ENABLE_NNS_TOPICS\":false,\"ENABLE_SNS_TOPICS\":true}"
+VITE_FEATURE_FLAGS="{\"DISABLE_IMPORT_TOKEN_VALIDATION_FOR_TESTING\":false,\"ENABLE_APY_PORTFOLIO\":false,\"ENABLE_CKTESTBTC\":false,\"ENABLE_DISBURSE_MATURITY\":true,\"ENABLE_LAUNCHPAD_REDESIGN\":false,\"ENABLE_NNS_TOPICS\":false,\"ENABLE_SNS_TOPICS\":true}"
 VITE_HOST=https://icp-api.io
 VITE_IDENTITY_SERVICE_URL=https://identity.internetcomputer.org/
 VITE_ICP_SWAP_URL=https://uvevg-iyaaa-aaaak-ac27q-cai.raw.ic0.app/