chore: Implement ErrorReproducibility for crypto errors occurring during IDKG payload validation
#5964
+223
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eichhorl
changed the title
ErrorReproducibility for crypto errors occurring during IDKG payload validation
github-actions
bot
added
@crypto-team
@consensus
@ic-interface-owners
@ic-owners-owners
labels
basvandijk
approved these changes
Jul 17, 2025
berestovskyy
approved these changes
Jul 17, 2025
altkdf
approved these changes
Jul 18, 2025
Sawchord
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During IDKG payload validation, non-reproducible errors should be retried. To allow this, we implement the
ErrorReproducibilitytrait for all possible crypto errors.The validator then determines if the received error should be wrapped into an
InvalidIDkgPayloadReason(meaning the payload is reproducibly invalid) orIDkgPayloadValidationFailure(meaning the validation should be retried later) based on the result returned by theErrorReproducibilityimplementation.