Merge branch 'main' into ens/refuse-fetch-mainnet-root-key

Author: ericswanson-dfinity

.github/workflows/conventional-commits.yml

@@ -20,11 +20,13 @@ jobs:
         # verb: feat, fix, ...
         # scope: refers to the part of code being changed.  E.g. " (accounts)" or " (accounts,canisters)"
         # !: Indicates that the PR contains a breaking change.
-      - run: |
-          if [[ "${{ github.event.pull_request.title }}" =~ ^(feat|fix|chore|build|ci|docs|style|refactor|perf|test)(\([-a-zA-Z0-9,]+\))?\!?\: ]]; then
+      - env:
+          TITLE: ${{ github.event.pull_request.title }}
+        run: |
+          echo "PR title: $TITLE"
+          if [[ "$TITLE" =~ ^(feat|fix|chore|build|ci|docs|style|refactor|perf|test)(\([-a-zA-Z0-9,]+\))?\!?\: ]]; then
               echo pass
           else
               echo "PR title does not match conventions"
-              echo "PR title: ${{ github.event.pull_request.title }}"
               exit 1
           fi

.github/workflows/e2e.yml

@@ -10,7 +10,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ macos-latest, ubuntu-latest ]
+        os: [ macos-12, ubuntu-latest ]
         dfx: [ '0.8.4', '0.9.2', '0.10.1', '0.11.1' ]
 
     steps:

.github/workflows/ic-ref.yml

@@ -28,7 +28,7 @@ jobs:
       - name: Install dfx
         uses: dfinity/setup-dfx@main
         with:
-          dfx-version: "0.16.1"
+          dfx-version: "latest"
 
       - name: Cargo cache
         uses: actions/cache@v4

.github/workflows/lint.yml

@@ -21,10 +21,17 @@ jobs:
             target
           key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
 
+      - uses: taiki-e/install-action@v2
+        with:
+          tool: cargo-hack@0.6.21
+
       - name: Run Lint
-        run: cargo clippy --verbose --tests --benches -- -D warnings
+        run: |
+          cargo hack clippy --each-feature --exclude-features ic_ref_tests --no-dev-deps --verbose -- -D warnings
+          cargo clippy --features ic_ref_tests --verbose --tests --benches -- -D warnings
         env:
           RUST_BACKTRACE: 1
+
       - name: Run Lint (WASM)
         run: CARGO_TARGET_DIR=target/wasm cargo clippy --target wasm32-unknown-unknown -p ic-agent --features wasm-bindgen -p ic-utils --verbose -- -D warnings
   aggregate:

.github/workflows/release.yml

@@ -19,13 +19,16 @@ jobs:
             target: x86_64-unknown-linux-musl
             binary_path: target/x86_64-unknown-linux-musl/release
             binary_files: icx
-          - os: macos-latest
+          - os: macos-12
             name: macos
             target: x86_64-apple-darwin
             binary_path: target/x86_64-apple-darwin/release
             binary_files: icx
     steps:
     - uses: actions/checkout@v4
+    - uses: taiki-e/install-action@v2
+      with:
+        tool: cross@0.2.5
 
     - name: Setup environment variables
       run: |
@@ -37,24 +40,21 @@ jobs:
         echo "END" >> $GITHUB_ENV
 
     - name: Build
-      uses: ructions/cargo@v1
-      with:
-        command: build
-        args: --target ${{ matrix.target }} ${{ env.cargo_build_ARGS }}
-        use-cross: ${{ contains(matrix.os, 'ubuntu') }}
+      run: |
+        cross build --target ${{ matrix.target }} ${{ env.cargo_build_ARGS }}
 
     - name: Strip binaries
       run: |
         cd ${{ matrix.binary_path }}
         sudo chown -R $(whoami) .
         strip ${{ matrix.binary_files }}
-      if: contains(matrix.os, 'ubuntu')
+      if: ${{ contains(matrix.os, 'ubuntu') }}
 
     - name: Check linkage
       run: |
         cd ${{ matrix.binary_path }}
         otool -L ${{ matrix.binary_files }}
-      if: contains(matrix.os, 'macos')
+      if: ${{ contains(matrix.os, 'macos') }}
 
     - name: Create tarball of binaries
       if: ${{ github.event_name == 'push' }}

.github/workflows/shellcheck.yml

@@ -14,8 +14,8 @@ on:
 
 jobs:
   check_macos:
-    # ubuntu-latest has shellcheck 0.4.6, while macos-latest has 0.7.1
-    runs-on: macos-latest
+    # ubuntu-latest has shellcheck 0.4.6, while macos-12 has 0.7.1
+    runs-on: macos-12
     steps:
       - uses: actions/checkout@v4
       - name: Install shellcheck

CHANGELOG.md

@@ -8,18 +8,40 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+* Added a limit to the concurrent requests an agent will make at once. This should make server-side ratelimiting much rarer to encounter, even when sending a high volume of requests (for example, a large `ic_utils::ManagementCanister::install` call).
+* The agent will now automatically retry 429 Too Many Requests responses after a short delay.
+* BREAKING: Changed Chunk Store API to conform to the interface specification:
+  * `ChunkHash` was changed from `[u8; 32]` to a struct.
+  * Return types of `ManagementCanister::stored_chunks()` and `ManagementCanister::upload_chunk()`.
+  * Argument type of `ManagementCanister::install_chunked_code()`.
+  * `InstallChunkedCodeBuilder`.
+    * All occurrences of `storage_canister` were changed to `store_canister`.
+    * The field `chunk_hashes_list` was changed from `vec<vec<u8>>` to `vec<ChunkHash>`.
+* Changed `WalletCanister::from_canister/create`'s version check to not rely on the reject code.
+* Added `QueryBuilder::call_with_verification()` and `QueryBuilder::call_without_verification()` which always/never verify query signatures
+  regardless the Agent level configuration from `AgentBuilder::with_verify_query_signatures`.
+* Function `Agent::fetch_api_boundary_nodes()` is split into two functions: `fetch_api_boundary_nodes_by_canister_id()` and `fetch_api_boundary_nodes_by_subnet_id()`.
+* `ReqwestTransport` and `HyperTransport` structures storing the trait object `route_provider: Box<dyn RouteProvider>` have been modified to allow for shared ownership via `Arc<dyn RouteProvider>`.
+* Added `wasm_memory_limit` to canister creation and canister setting update options.
+* Agent::fetch_root_key() now returns an error, and sets its root key to an empty vector, if got the same root key as the mainnet. This reduce the potentiality of MITM attack.
+ 
+## [0.34.0] - 2024-03-18
+
+* Changed `AgentError::ReplicaError` to `CertifiedReject` or `UncertifiedReject`. `CertifiedReject`s went through consensus, and `UncertifiedReject`s did not. If your code uses `ReplicaError`:
+    * for queries: use `UncertifiedReject` in all cases (for now)
+    * for updates: use `CertifiedReject` for errors raised after the message successfully reaches the canister, and `UncertifiedReject` otherwise
 * Added `Agent::fetch_api_boundary_nodes` for looking up API boundary nodes in the state tree.
 * Timestamps are now being checked in `Agent::verify` and `Agent::verify_for_subnet`. If you were using it with old certificates, increase the expiry timeout to continue to verify them.
 * Added node metrics, ECDSA, and Bitcoin functions to `MgmtMethod`. Most do not have wrappers in `ManagementCanister` because only canisters can call these functions.
 * Added `FetchCanisterLogs` function to `MgmtMethod` and a corresponding wrapper to `ManagementCanister`.
 * Updated the `ring` crate to 0.17.7.  `ring` 0.16 has a bug where it requires incorrect Ed25519 PEM encoding. 0.17.7 fixes that and is backwards compatible.
-* Agent::fetch_root_key() now returns an error, and sets its root key to an empty vector, if got the same root key as the mainnet. This reduce the potentiality of MITM attack.
+* Removed serde and candid serialization traits from the `Status` type.
+* Added commas and newlines to the `Status` fmt::Display output. It is valid JSON now (it was close before).
 
 ## [0.33.0] - 2024-02-08
 
 * Changed the return type of `stored_chunks` to a struct.
 * Added a prime256v1-based `Identity` impl to complement the ed25519 and secp256k1 `Identity` impls.
-* Added serde and candid serialization traits to the `Status` type.
 * Changed the type of `InstallMode.skip_pre_upgrade` from `bool` to `Option<bool>` to match the interface specification.
 
 ## [0.32.0] - 2024-01-18