Skip to content

Commit f224fdd

Browse files
author
Andres Garcia
committed
Adjusted few lines to comply with feedback.
1 parent 7881865 commit f224fdd

File tree

1 file changed

+9
-12
lines changed

1 file changed

+9
-12
lines changed

src/databricks/labs/ucx/installer/workflows.py

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -173,22 +173,22 @@
173173
174174
# DBTITLE 1,Assessment Export
175175
FILE_NAME = "ucx_assessment_main.xlsx"
176-
UCX_PATH = f"/Workspace{{ctx.installation.install_folder()}}"
177-
DOWNLOAD_PATH = "/dbfs/FileStore/excel-export"
176+
UCX_PATH = Path(f"/Workspace{ctx.installation.install_folder()}")
177+
DOWNLOAD_PATH = Path("/dbfs/FileStore/excel-export/")
178178
179179
180180
def _cleanup() -> None:
181181
'''Move the temporary results file to the download path and clean up the temp directory.'''
182182
shutil.move(
183-
os.path.join(UCX_PATH + "/tmp/", FILE_NAME),
184-
os.path.join(DOWNLOAD_PATH, FILE_NAME),
183+
UCX_PATH / "tmp" / FILE_NAME,
184+
DOWNLOAD_PATH / FILE_NAME,
185185
)
186-
shutil.rmtree(UCX_PATH + "/tmp/")
186+
shutil.rmtree(UCX_PATH / "tmp/")
187187
188188
189189
def _prepare_directories() -> None:
190190
'''Ensure that the necessary directories exist.'''
191-
os.makedirs(UCX_PATH + "/tmp/", exist_ok=True)
191+
os.makedirs(UCX_PATH / "tmp/", exist_ok=True)
192192
os.makedirs(DOWNLOAD_PATH, exist_ok=True)
193193
194194
@@ -214,14 +214,11 @@ def export_results() -> None:
214214
'''Main method to export results to an Excel file.'''
215215
_prepare_directories()
216216
217-
assessment_dashboard = next(d for d in os.listdir(UCX_PATH + "/dashboards") if "Assessment (Main)" in d)
218-
dashboard_path = Path(ctx.installation.install_folder()) / "dashboards" / assessment_dashboard
219-
220-
dashboard = Dashboards(ctx.workspace_client)
221-
dashboard_datasets = dashboard.get_dashboard(dashboard_path).datasets
217+
assessment_dashboard = next(UCX_PATH.glob("dashboards/*Assessment (Main)*"))
218+
dashboard_datasets = Dashboards(ctx.workspace_client).get_dashboard(assessment_dashboard).datasets
222219
223220
try:
224-
target = UCX_PATH + "/tmp/ucx_assessment_main.xlsx"
221+
target = UCX_PATH / "tmp/ucx_assessment_main.xlsx"
225222
with pd.ExcelWriter(target, engine="xlsxwriter") as writer:
226223
tasks = []
227224
for dataset in dashboard_datasets:

0 commit comments

Comments
 (0)