Skip to content

Commit 8a1893c

Browse files
committed
merging
1 parent 6915b2f commit 8a1893c

File tree

1 file changed

+10
-12
lines changed

1 file changed

+10
-12
lines changed

src/databricks/labs/ucx/hive_metastore/mapping.py

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ def unskip_table_or_view(self, schema_name: str, table_name: str, load_table: Ca
153153
)
154154
except BadRequest as err:
155155
logger.error(f"Failed to apply skip marker for Table {schema_name}.{table_name}: {err!s}", exc_info=True)
156+
156157
def skip_schema(self, schema: str):
157158
# Marks a schema to be skipped in the migration process by applying a table property
158159
try:
@@ -167,22 +168,19 @@ def skip_schema(self, schema: str):
167168
except BadRequest as err:
168169
logger.error(err)
169170

170-
def unskip_schema(self, schema: str) -> None:
171-
"""Removes skip mark from the schema property.
172-
Args:
173-
schema (String): The schema name of the table to be unskipped.
174-
"""
171+
def unskip_schema(self, schema: str):
172+
# Removes skip mark from the schema property
175173
try:
176174
self._sql_backend.execute(
177-
f"ALTER SCHEMA hive_metastore.{escape_sql_identifier(schema)} UNSET DBPROPERTIES IF EXISTS('{self.UCX_SKIP_PROPERTY}');"
175+
f"ALTER SCHEMA {escape_sql_identifier(schema)} UNSET DBPROPERTIES IF EXISTS('{self.UCX_SKIP_PROPERTY}');"
178176
)
179-
except NotFound as e:
180-
if "[SCHEMA_NOT_FOUND]" in str(e):
181-
logger.error(f"Failed to remove skip marker from schema: {schema}. Schema not found.", exc_info=e)
177+
except NotFound as err:
178+
if "[SCHEMA_NOT_FOUND]" in str(err):
179+
logger.error(f"Failed to remove skip marker for Schema {schema}. Schema not found.")
182180
else:
183-
logger.error(f"Failed to remove skip marker from schema: {schema}.", exc_info=e)
184-
except BadRequest as e:
185-
logger.error(f"Failed to remove skip marker from schema: {schema}.", exc_info=e)
181+
logger.error(err)
182+
except BadRequest as err:
183+
logger.error(err)
186184

187185
def get_tables_to_migrate(self, tables_crawler: TablesCrawler) -> Collection[TableToMigrate]:
188186
rules = self.load()

0 commit comments

Comments
 (0)