OPIK-2075: Remove project level implementation for thread inactive timeout (#2758)

* OPIK-2075: Remove project level implementation for thread inactive timeout

* Remove tests

Author: thiagohora

apps/opik-backend/src/main/java/com/comet/opik/api/Project.java

@@ -7,7 +7,6 @@
 import com.fasterxml.jackson.databind.annotation.JsonNaming;
 import io.swagger.v3.oas.annotations.media.Schema;
 import jakarta.annotation.Nullable;
-import jakarta.validation.Valid;
 import jakarta.validation.constraints.NotBlank;
 import lombok.Builder;
 
@@ -50,9 +49,7 @@ public record Project(
         @JsonView({
                 Project.View.Detailed.class}) @Schema(accessMode = Schema.AccessMode.READ_ONLY) @Nullable Long guardrailsFailedCount,
         @JsonView({
-                Project.View.Detailed.class}) @Schema(accessMode = Schema.AccessMode.READ_ONLY) @Nullable ErrorCountWithDeviation errorCount,
-        @JsonView({Project.View.Public.class, Project.View.Detailed.class,
-                View.Write.class}) @Nullable @Valid Configuration configuration){
+                Project.View.Detailed.class}) @Schema(accessMode = Schema.AccessMode.READ_ONLY) @Nullable ErrorCountWithDeviation errorCount){
 
     @Builder(toBuilder = true)
     @JsonIgnoreProperties(ignoreUnknown = true)

apps/opik-backend/src/main/java/com/comet/opik/api/resources/v1/priv/ProjectsResource.java

@@ -40,7 +40,6 @@
 import jakarta.ws.rs.GET;
 import jakarta.ws.rs.PATCH;
 import jakarta.ws.rs.POST;
-import jakarta.ws.rs.PUT;
 import jakarta.ws.rs.Path;
 import jakarta.ws.rs.PathParam;
 import jakarta.ws.rs.Produces;
@@ -58,7 +57,6 @@
 import java.util.Optional;
 import java.util.UUID;
 
-import static com.comet.opik.api.Project.Configuration;
 import static com.comet.opik.api.Project.ProjectPage;
 import static com.comet.opik.api.Project.View;
 import static com.comet.opik.domain.ProjectMetricsService.ERR_START_BEFORE_END;
@@ -302,25 +300,4 @@ public Response getProjectStats(
         return Response.ok().entity(projectStatisticsSummary).build();
     }
 
-    @PUT
-    @Path("/{id}/configurations")
-    @Operation(operationId = "upsertProjectConfigurations", summary = "Upsert project configurations", description = "Upsert project configurations", responses = {
-            @ApiResponse(responseCode = "204", description = "No Content"),
-            @ApiResponse(responseCode = "400", description = "Bad Request", content = @Content(schema = @Schema(implementation = ErrorMessage.class))),
-            @ApiResponse(responseCode = "422", description = "Unprocessable Content", content = @Content(schema = @Schema(implementation = ErrorMessage.class))),
-            @ApiResponse(responseCode = "404", description = "Not Found", content = @Content(schema = @Schema(implementation = ErrorMessage.class)))
-    })
-    public Response upsertProjectConfigurations(
-            @PathParam("id") UUID projectId,
-            @RequestBody(content = @Content(schema = @Schema(implementation = Configuration.class))) @Valid Configuration configuration) {
-        String workspaceId = requestContext.get().getWorkspaceId();
-
-        log.info("Setting project configuration for project '{}' on workspaceId '{}'", projectId, workspaceId);
-
-        projectService.updateConfiguration(projectId, configuration);
-
-        log.info("Set project configuration for project '{}' on workspaceId '{}'", projectId, workspaceId);
-
-        return Response.ok().build();
-    }
 }

apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectConfigDAO.java

@@ -33,7 +33,6 @@
 import org.jdbi.v3.core.statement.UnableToExecuteStatementException;
 import reactor.core.publisher.Mono;
 import reactor.core.scheduler.Schedulers;
-import reactor.util.context.Context;
 import ru.vyarus.guicey.jdbi3.tx.TransactionTemplate;
 
 import java.sql.SQLIntegrityConstraintViolationException;
@@ -127,7 +126,6 @@ record ProjectRecordSet(List<Project> content, long total) {
     private final @NonNull TransactionTemplateAsync transactionTemplateAsync;
     private final @NonNull SortingFactoryProjects sortingFactory;
     private final @NonNull SortingQueryBuilder sortingQueryBuilder;
-    private final @NonNull ProjectConfigDAO projectConfigDAO;
 
     private NotFoundException createNotFoundError() {
         String message = "Project not found";
@@ -141,19 +139,8 @@ public Project create(@NonNull Project project) {
         UUID projectId = idGenerator.generateId();
         String userName = requestContext.get().getUserName();
         String workspaceId = requestContext.get().getWorkspaceId();
-        Configuration configuration = project.configuration();
 
-        project = createProject(project, projectId, userName, workspaceId).toBuilder()
-                .configuration(configuration)
-                .build();
-
-        if (project.configuration() != null) {
-            projectConfigDAO.upsertConfigurations(project)
-                    .contextWrite(ctx -> setContext(ctx, workspaceId, userName))
-                    .block();
-        }
-
-        return project;
+        return createProject(project, projectId, userName, workspaceId);
     }
 
     private Project createProject(Project project, UUID projectId, String userName, String workspaceId) {
@@ -246,13 +233,8 @@ public Project get(@NonNull UUID id, @NonNull String workspaceId) {
                 .nonTransaction(connection -> traceDAO.getLastUpdatedTraceAt(Set.of(id), workspaceId, connection))
                 .block();
 
-        Configuration configuration = projectConfigDAO.getConfigurations(id)
-                .contextWrite(ctx -> setContext(ctx, workspaceId, "unused")) // userName is not used in this context
-                .block();
-
         return project.toBuilder()
                 .lastUpdatedTraceAt(lastUpdatedTraceAt.get(project.id()))
-                .configuration(configuration)
                 .build();
     }
 
@@ -283,13 +265,7 @@ public void updateConfiguration(@NonNull UUID projectId, @NonNull Configuration
         String workspaceId = requestContext.get().getWorkspaceId();
         String userName = requestContext.get().getUserName();
 
-        Project project = get(projectId).toBuilder()
-                .configuration(configuration)
-                .build();
-
-        projectConfigDAO.upsertConfigurations(project)
-                .contextWrite(ctx -> setContext(ctx, workspaceId, userName))
-                .block();
+        Project project = get(projectId);
     }
 
     private ProjectStatsSummaryItem getStats(UUID projectId, Map<String, Object> projectStats) {
@@ -326,11 +302,6 @@ public void delete(@NonNull UUID id) {
             // Void return
             return null;
         });
-
-        projectConfigDAO.deleteConfigurationsByProjectId(List.of(id))
-                .contextWrite(ctx -> ctx.put(RequestContext.USER_NAME, userName)
-                        .put(RequestContext.WORKSPACE_ID, workspaceId))
-                .block();
     }
 
     @Override
@@ -347,14 +318,6 @@ public void delete(Set<UUID> ids) {
             handle.attach(ProjectDAO.class).delete(ids, workspaceId);
             return null;
         });
-
-        projectConfigDAO.deleteConfigurationsByProjectId(List.copyOf(ids))
-                .contextWrite(ctx -> setContext(ctx, workspaceId, userName))
-                .block();
-    }
-
-    private static Context setContext(Context ctx, String workspaceId, String userName) {
-        return ctx.put(RequestContext.WORKSPACE_ID, workspaceId).put(RequestContext.USER_NAME, userName);
     }
 
     @Override
@@ -363,7 +326,6 @@ public Page<Project> find(int page, int size, @NonNull ProjectCriteria criteria,
 
         String workspaceId = requestContext.get().getWorkspaceId();
         Visibility visibility = requestContext.get().getVisibility();
-        String userName = requestContext.get().getUserName();
 
         if (!sortingFields.isEmpty() && sortingFields.getFirst().field().equals(SortableFields.LAST_UPDATED_TRACE_AT)) {
             return findWithLastTraceSorting(page, size, criteria, sortingFields.getFirst());
@@ -391,19 +353,12 @@ public Page<Project> find(int page, int size, @NonNull ProjectCriteria criteria,
                 .nonTransaction(connection -> traceDAO.getLastUpdatedTraceAt(projectIds, workspaceId, connection))
                 .block();
 
-        Map<UUID, Configuration> projectsConfigurations = projectConfigDAO
-                .getConfigurationsByIds(projectRecordSet.content().stream().map(Project::id).collect(toSet()))
-                .contextWrite(ctx -> setContext(ctx, workspaceId, userName))
-                .block();
-
         List<Project> projects = projectRecordSet.content()
                 .stream()
                 .map(project -> {
                     Instant lastUpdatedTraceAt = projectLastUpdatedTraceAtMap.get(project.id());
-                    Configuration configuration = projectsConfigurations.get(project.id());
                     return project.toBuilder()
                             .lastUpdatedTraceAt(lastUpdatedTraceAt)
-                            .configuration(configuration)
                             .build();
                 })
                 .toList();
@@ -481,17 +436,11 @@ private Page<Project> findWithLastTraceSorting(int page, int size, @NonNull Proj
             return repository.findByIds(new HashSet<>(finalIds), workspaceId);
         }).stream().collect(Collectors.toMap(Project::id, Function.identity()));
 
-        Map<UUID, Configuration> projectsConfigurations = projectConfigDAO
-                .getConfigurationsByIds(allProjectIds)
-                .contextWrite(ctx -> setContext(ctx, workspaceId, userName))
-                .block();
-
         // compose the final projects list by the correct order and add last trace to it
         List<Project> projects = finalIds.stream()
                 .map(projectsById::get)
                 .map(project -> project.toBuilder()
                         .lastUpdatedTraceAt(projectLastUpdatedTraceAtMap.get(project.id()))
-                        .configuration(projectsConfigurations.get(project.id()))
                         .build())
                 .toList();
 
@@ -585,10 +534,6 @@ public Project retrieveByName(@NonNull String projectName) {
                     Map<UUID, Map<String, Object>> projectStats = getProjectStats(List.of(project.id()),
                             workspaceId);
 
-                    Configuration configuration = projectConfigDAO.getConfigurations(project.id())
-                            .contextWrite(ctx -> setContext(ctx, workspaceId, userName))
-                            .block();
-
                     return project.toBuilder()
                             .lastUpdatedTraceAt(projectLastUpdatedTraceAtMap.get(project.id()))
                             .feedbackScores(StatsMapper.getStatsFeedbackScores(projectStats.get(project.id())))
@@ -602,7 +547,6 @@ public Project retrieveByName(@NonNull String projectName) {
                             .guardrailsFailedCount(
                                     StatsMapper.getStatsGuardrailsFailedCount(projectStats.get(project.id())))
                             .errorCount(StatsMapper.getStatsErrorCount(projectStats.get(project.id())))
-                            .configuration(configuration)
                             .build();
                 })
                 .orElseThrow(this::createNotFoundError);