Skip to content

Commit 77a2aff

Browse files
authored
Merge pull request #24 from snewcomer/upgrade-2.17
Upgrade to 2.17
2 parents 9840c5b + cb06f25 commit 77a2aff

File tree

11 files changed

+598
-300
lines changed

11 files changed

+598
-300
lines changed

.npmignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,8 @@
1414
bower.json
1515
ember-cli-build.js
1616
testem.js
17+
18+
# ember-try
19+
.node_modules.ember-try/
20+
bower.json.ember-try
21+
package.json.ember-try

.travis.yml

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,23 @@ node_js:
88
sudo: false
99
dist: trusty
1010

11-
cache:
12-
yarn: true
13-
directories:
14-
- $HOME/.cache # includes bowers cache
15-
1611
addons:
1712
chrome: stable
1813

14+
cache:
15+
yarn: true
16+
1917
env:
2018
global:
2119
# See https://git.io/vdao3 for details.
2220
- JOBS=1
2321
matrix:
24-
# we recommend testing LTS's and latest stable release (bonus points to beta/canary)
22+
# we recommend new addons test the current and previous LTS
23+
# as well as latest stable release (bonus points to beta/canary)
2524
- EMBER_TRY_SCENARIO=ember-lts-2.4
2625
- EMBER_TRY_SCENARIO=ember-lts-2.8
2726
- EMBER_TRY_SCENARIO=ember-lts-2.12
27+
- EMBER_TRY_SCENARIO=ember-lts-2.16
2828
- EMBER_TRY_SCENARIO=ember-release COVERAGE=true
2929
- EMBER_TRY_SCENARIO=ember-beta
3030
- EMBER_TRY_SCENARIO=ember-canary
@@ -38,20 +38,17 @@ matrix:
3838
before_install:
3939
- curl -o- -L https://yarnpkg.com/install.sh | bash
4040
- export PATH=$HOME/.yarn/bin:$PATH
41-
- if [[ $(npm -v | cut -d '.' -f 1) -lt 3 ]]; then npm i -g npm@^3; fi
42-
- yarn global add bower
43-
- bower install
4441

4542
install:
4643
- yarn install --no-lockfile --non-interactive
4744

4845
script:
4946
# Usually, it's ok to finish the test scenario without reverting
5047
# to the addon's original dependency state, skipping "cleanup".
51-
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO test --skip-cleanup
48+
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO --skip-cleanup
5249

5350
after_script:
5451
- cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js
5552

5653
notifications:
57-
email: false
54+
email: false

app/initializers/ember-stripe-elements.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export function initialize() {
1010
application.inject('service:stripev3', 'config', 'config:stripe');
1111

1212
if (!stripeConfig.publishableKey) {
13-
throw new Ember.Error("stripev3: Missing Stripe key, please set `ENV.stripe.publishableKey` in config.environment.js");
13+
throw new EmberError("stripev3: Missing Stripe key, please set `ENV.stripe.publishableKey` in config.environment.js");
1414
}
1515

1616
if (typeof FastBoot !== 'undefined' || stripeConfig.mock) {

config/ember-try.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,14 @@ module.exports = {
4242
}
4343
}
4444
},
45+
{
46+
name: 'ember-lts-2.16',
47+
npm: {
48+
devDependencies: {
49+
'ember-source': '~2.16.0'
50+
}
51+
}
52+
},
4553
{
4654
name: 'ember-release',
4755
bower: {

package.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,35 +18,35 @@
1818
"repository": "https://github.com/code-corps/ember-stripe-elements",
1919
"scripts": {
2020
"build": "ember build",
21-
"start": "ember server",
21+
"start": "ember serve",
2222
"test": "ember try:each"
2323
},
2424
"dependencies": {
25-
"ember-cli-babel": "^6.3.0",
25+
"ember-cli-babel": "^6.6.0",
2626
"ember-cli-htmlbars": "^2.0.1",
27-
"ember-cli-htmlbars-inline-precompile": "^0.4.3"
27+
"ember-cli-htmlbars-inline-precompile": "^1.0.0"
2828
},
2929
"devDependencies": {
3030
"broccoli-asset-rev": "^2.4.5",
3131
"coveralls": "^2.12.0",
3232
"ember-ajax": "^3.0.0",
33-
"ember-cli": "~2.14.2",
33+
"ember-cli": "~2.17.1",
3434
"ember-cli-code-coverage": "0.3.11",
35-
"ember-cli-dependency-checker": "^1.3.0",
35+
"ember-cli-dependency-checker": "^2.0.0",
3636
"ember-cli-eslint": "^4.2.2",
3737
"ember-cli-inject-live-reload": "^1.4.1",
38-
"ember-cli-qunit": "^4.0.0",
39-
"ember-cli-shims": "^1.1.0",
38+
"ember-cli-qunit": "^4.1.1",
39+
"ember-cli-shims": "^1.2.0",
4040
"ember-cli-sri": "^2.1.0",
41-
"ember-cli-uglify": "^1.2.0",
41+
"ember-cli-uglify": "^2.0.0",
4242
"ember-disable-prototype-extensions": "^1.1.2",
4343
"ember-export-application-global": "^2.0.0",
4444
"ember-load-initializers": "^1.0.0",
4545
"ember-qunit-assert-helpers": "^0.2.1",
4646
"ember-resolver": "^4.0.0",
4747
"ember-sinon": "^1.0.1",
4848
"ember-sinon-qunit": "1.4.1",
49-
"ember-source": "~2.14.1",
49+
"ember-source": "~2.17.0",
5050
"loader.js": "^4.2.3"
5151
},
5252
"engines": {

testem.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
/* eslint-env node */
22
module.exports = {
3-
"test_page": "tests/index.html?hidepassed",
4-
"disable_watching": true,
5-
"launch_in_ci": [
6-
"Chrome"
3+
test_page: 'tests/index.html?hidepassed',
4+
disable_watching: true,
5+
launch_in_ci: [
6+
'Chrome'
77
],
8-
"launch_in_dev": [
9-
"Chrome"
8+
launch_in_dev: [
9+
'Chrome'
1010
],
1111
browser_args: {
1212
Chrome: {
1313
mode: 'ci',
1414
args: [
1515
'--disable-gpu',
1616
'--headless',
17-
'--remote-debugging-port=9222',
17+
'--remote-debugging-port=0',
1818
'--window-size=1440,900'
1919
]
20-
},
20+
}
2121
}
2222
};

tests/dummy/app/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99

1010
{{content-for "head"}}
1111

12-
<link rel="stylesheet" href="{{rootURL}}assets/vendor.css">
13-
<link rel="stylesheet" href="{{rootURL}}assets/dummy.css">
12+
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css">
13+
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/dummy.css">
1414

1515
{{content-for "head-footer"}}
1616
</head>

tests/helpers/module-for-acceptance.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { resolve } from 'rsvp';
21
import { module } from 'qunit';
2+
import { resolve } from 'rsvp';
33
import startApp from '../helpers/start-app';
44
import destroyApp from '../helpers/destroy-app';
55

tests/helpers/start-app.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import { run } from '@ember/runloop';
2-
import { merge } from '@ember/polyfills';
31
import Application from '../../app';
42
import config from '../../config/environment';
3+
import { merge } from '@ember/polyfills';
4+
import { run } from '@ember/runloop';
55

66
export default function startApp(attrs) {
77
let attributes = merge({}, config.APP);

tests/test-helper.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
import resolver from './helpers/resolver';
2-
import {
3-
setResolver
4-
} from 'ember-qunit';
5-
import { start } from 'ember-cli-qunit';
1+
import Application from '../app';
2+
import { setApplication } from '@ember/test-helpers';
3+
import { start } from 'ember-qunit';
4+
5+
setApplication(Application.create({ autoboot: false }));
66

7-
setResolver(resolver);
87
start();

0 commit comments

Comments
 (0)