Skip to content

Commit d2c818b

Browse files
authored
Merge pull request #905 from cmu-delphi/sgratzl/fix_typo
fix: correlation table lag rendering
2 parents f8a2795 + c93a18a commit d2c818b

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/data/correlation.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ function generateLags(a, b) {
7979
const bLag = b.slice(lag - i, b.length - i);
8080
const bValuesLag = bValues.slice(lag - i, b.length - i);
8181
const model = linear(zip(aWindowValues, bValuesLag));
82-
lags.push(asLag(-i, model, aWindow, bLag));
82+
lags.push(asLag(i === 0 ? 0 : -i, model, aWindow, bLag));
8383
}
8484

8585
for (let i = 1; i <= lag; i++) {

src/data/correlationUtils.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* @returns string
55
*/
66
export function lagToOffset(lag, wrapped = true) {
7-
const wrap = wrapped ? (v) => ` (${v})` : (v) => ` ${v}`;
7+
const wrap = wrapped === 'zero' ? String : wrapped ? (v) => ` (${v})` : (v) => ` ${v}`;
88
if (lag === 1) {
99
return wrap('1 day later');
1010
}
@@ -17,5 +17,8 @@ export function lagToOffset(lag, wrapped = true) {
1717
if (lag < -1) {
1818
return wrap(`${-lag} days earlier`);
1919
}
20+
if (wrapped === 'zero') {
21+
return '0 days';
22+
}
2023
return '';
2124
}

0 commit comments

Comments
 (0)