Merge pull request #1176 from cmu-delphi/sgratzl/fix_formatting

fix Cornercase in rounding

Author: sgratzl

src/components/KPIValue.svelte

@@ -12,11 +12,12 @@
   export let loading = false;
 
   $: scaled = value != null && !Number.isNaN(value) ? value * factor : null;
+  $: digitsPow = Math.pow(10, digits);
+  $: roundedValue = Math.round(Math.abs(scaled) * digitsPow);
 
   $: hasFraction = loading || (scaled != null && digits > 0 && Math.floor(scaled) !== scaled);
-  $: base = loading ? '00' : scaled == null ? 'N/A' : Math.floor(scaled);
-  $: digitsPow = Math.pow(10, digits);
-  $: fraction = !loading && hasFraction ? Math.round(Math.abs(scaled) * digitsPow) % digitsPow : 0;
+  $: base = loading ? '00' : scaled == null ? 'N/A' : Math.floor(roundedValue / digitsPow);
+  $: fraction = !loading && hasFraction ? roundedValue % digitsPow : 0;
 </script>
 
 <KPI text={base.toLocaleString()} sub={hasFraction ? `.${fraction}` : null} {loading} />