Skip to content

BroadcastsData::serializeData() does not appear to process $includePaths parameter correctly. #647

@k8n

Description

@k8n

return $this->broadcastEncoder()->serializeData($data, $params);

BroadcastsData::serializeData() appears to call Encoder::serializeData().
Encoder::serializeData() does not appear to take a second parameter. And thus no matter if includes are specified or not, the data going down the broadcast wire will have no includes. Below is what BroadcastsData::serializeData() should probably look like.

// BroadcastsData.php
// ...

    protected function serializeData($data, $includePaths = null, array $fieldsets = null)
    {
        $params = new QueryParameters($includePaths ? (array) $includePaths : null, $fieldsets);

        return $this->broadcastEncoder()->withEncodingParameters($params)->serializeData($data);
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions