Skip to content

Commit 64e861a

Browse files
committed
cmake: we were missing linking against combase.dll
1 parent 8720356 commit 64e861a

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

cmake/libremidi.winmidi.cmake

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,4 @@ target_include_directories(libremidi SYSTEM ${_public}
7373
)
7474
target_compile_definitions(libremidi ${_public} LIBREMIDI_WINMIDI)
7575
set(LIBREMIDI_HAS_WINMIDI 1)
76-
target_link_libraries(libremidi ${_public} RuntimeObject)
77-
if(MSVC)
78-
target_link_libraries(libremidi ${_public} windowsapp)
79-
endif()
76+
target_link_libraries(libremidi ${_public} RuntimeObject windowsapp)

cmake/libremidi.winuwp.cmake

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,10 @@ if(CPPWINRT_PATH)
1919

2020
target_include_directories(libremidi SYSTEM ${_public} "${CPPWINRT_PATH}")
2121
target_compile_definitions(libremidi ${_public} LIBREMIDI_WINUWP)
22-
target_link_libraries(libremidi INTERFACE RuntimeObject)
22+
target_link_libraries(libremidi INTERFACE RuntimeObject windowsapp)
2323
# We don't need /ZW option here (support for C++/CX)' as we use C++/WinRT
2424
if(MSVC)
2525
target_compile_options(libremidi ${_public} /EHsc)
26-
target_link_libraries(libremidi ${_public} windowsapp)
2726
endif()
2827
else()
2928
message(STATUS "libremidi: Failed to find Windows SDK, UWP MIDI backend will not be available")

0 commit comments

Comments
 (0)