[Bug] Does not respect silent/quiet output verbosity level

[llaville]

Hello,

I've tried yesterday, for the first time, your project, and I love this great tool.

BTW, I've noticed on testing a pre-commit hook like this : vendor/bin/captainhook hook:pre-commit --silent that latest version in date (5.25.6) does not respect the Symfony/Console Silent Verbosity option.

I've in mind a little code change like that :

<?php
        $verbosity = $out->isSilent() ? OutputInterface::VERBOSITY_SILENT : max($confVerbosity, $cliVerbosity);
        $out->setVerbosity($verbosity);

into https://github.com/captainhook-git/captainhook/blob/5.25.6/src/Console/Command/ConfigAware.php#L120

but it will work only with latest symfony/console constraint
into https://github.com/captainhook-git/captainhook/blob/5.25.6/composer.json#L43

Hope you'll find a better compromise to satisfy all versions supported !

[llaville]

Oh, and I forgot to ask : Where can we find Documentation source code ?

Because, at https://php.captainhook.info/configure.html#settings we still see

[llaville]

PS: As Symfony explained, usage of SHELL_VERBOSITY is not supported too !

I.e:

• SHELL_VERBOSITY=-1 && vendor/bin/captainhook hook:pre-commit
• SHELL_VERBOSITY=-2 && vendor/bin/captainhook hook:pre-commit

[sebastianfeldmann]

I'm not sure how useful --silent is for the Cap'n. Because if your hooks are failing you want at least an error message to give you a hint what's going on.
You can use it, but i will always be mapped to at least quiet because as I said skipping all output is fine for me, but skipping error messages is not a good idea.

[llaville]

1. About documentation : the very-verbose level is not documented but implemented https://github.com/captainhook-git/captainhook/blob/5.25.6/src/Console/IOUtil.php#L34-L40

2. Of course I understand your point of view about --silent and error message, but I disagree that the behavior is mapped to quiet

See following screenshot

Reason is probably implementation of \CaptainHook\App\Console\Command\ConfigAware::determineVerbosity that take max value between configuration (default is set to normal that has a highest level to quiet) and CLI option value.

Symfony Console defines options literally :

      --silent                         Do not output any message
  -q, --quiet                          Only errors are displayed. All other output is suppressed

[llaville]

BTW, SHELL_VERBOSITY is implemented in Symfony/Console since v3.4.0 (see commit symfony/console@cdfd970) if you want to use it to map your literal config value

[sebastianfeldmann]

You are right, if you use --silent it is actually used. Since the Output::SILENT value is higher than the default Output::NORMAL value it should still be used with max. So now, if I don't actively prevent SILENT it can be used from the command line, but not from the Cap'n config. I think that's ok for now. Since I don't think it should be an option actively promoted by the Cap'n.
I mapped very verbose, but the Cap'n is not actively using it.

For the Cap'n there is only

• Quiet
• Normal
• Verbose
• Debug

// $confVerbosity will be mapped to normal :1
$confVerbosity = IOUtil::mapConfigVerbosity($config->getVerbosity());
// $cliVerbosity will return silent :8
$cliVerbosity  = $out->getVerbosity();
// verbosity will be set to silent
$out->setVerbosity(max($confVerbosity, $cliVerbosity));

[sebastianfeldmann]

After finally understanding what the issue is I fixed it in version 5.25.8

Since the cli verbosity was always at least NORMAL (32) you could not go less verbose by using the captainhook.json configuration file. So quiet in the config was not working.

I changed it so the default normal cli verbosity is ignored and if you change the CLI verbosity it overwrites the config verbosity.

Hope that fixes your problem. Sorry took me a while to really understand it.

Just as a side note: I will not add "silent" as a configuration option because I don't think it makes sense to use in the hook context.

Thanks for reporting the issue :)