node status

Author: bitrequest

assets_js_bitrequest_core.js

@@ -2835,7 +2835,7 @@ function topnotify(message) {
 // Displays styled notification in dialog boxes
 function popnotify(result, message) { // notifications in dialogs
     const notify_box = $(".popnotify");
-    if (result == "error") {
+    if (result === "error") {
         notify_box.removeClass("success warning").addClass("error");
     } else if (result == "warning") {
         notify_box.removeClass("success error").addClass("warning");

assets_js_bitrequest_monitors.js

@@ -569,7 +569,7 @@ function extract_error_details(error_obj) {
             "errormessage": error_obj
         }
     }
-    const error = q_obj(error_obj, "error");
+    const error = error_obj || q_obj(error_obj, "error");
     if (!error) return {
         "errorcode": 0,
         "errormessage": "unknown"

assets_js_bitrequest_rpcs.js

@@ -475,20 +475,19 @@ function validate_and_add_rpc_node(currency_name, api_list, node_id, node_config
 function create_rpc_node_element(api_list, is_live, node_id, node_config, is_selected) {
     const status_class = is_live ? " live" : " offline",
         selected_class = is_selected ? " rpc_selected" : "",
-        status_icon = is_live ? "connection" : "wifi-off",
         node_name = node_config.name,
         custom = node_config.custom,
         node_url = node_config.url,
         stripped_url = custom && (node_name == "alchemy" || node_name == "infura") ? strip_key_from_url(node_url) : node_url,
         vendor = node_config.vendor,
-        vendor_string = (vendor) ? " (" + vendor.slice(5) + ")" : "",
+        vendor_string = (vendor) ? "<span class='v'> (" + vendor.slice(5) + ")</span>" : "",
         version = node_config.v,
-        version_string = (version) ? " (" + version + ")" : "",
+        version_string = (version) ? "<span class='v'> (" + version + ")</span>" : "",
         display_name = setting_sub_address(node_name, stripped_url, node_config.custom) + vendor_string + version_string,
         node_icon_url = get_node_icon(node_name),
         default_class = custom ? "" : " default",
         node_icon = (node_icon_url) ? "<img src='" + fetch_aws(node_icon_url) + ".png' class='icon'>" : "",
-        node_element = $("<div class='optionwrap" + status_class + selected_class + default_class + "' style='display:none' data-pe='none' title='" + stripped_url + "'><span data-value='" + node_url + "' data-pe='none'>" + node_icon + display_name + "</span><div class='opt_icon_box' data-pe='none'><div class='opt_icon c_stat icon-" + status_icon + "' data-pe='none'></div><div class='opt_icon icon-bin' data-pe='none'></div></div>");
+        node_element = $("<div class='optionwrap" + status_class + selected_class + default_class + "' style='display:none' data-pe='none' title='" + stripped_url + "'><span data-value='" + node_url + "' data-pe='none'>" + node_icon + "<span class='cstat'>•</span> " + display_name + "</span><div class='opt_icon_box' data-pe='none'><div class='opt_icon icon-bin' data-pe='none'></div></div>");
     node_element.data(node_config).appendTo(api_list);
     node_element.slideDown(500);
 }
@@ -854,6 +853,11 @@ function test_mempoolspace(input_section, node_config, currency_name) {
         const parsed_data = br_result(response),
             api_result = parsed_data.result;
         if (api_result) {
+            if (api_result.error) {
+                const error_obj = extract_error_details(api_result.error);
+                popnotify("error", error_obj.errormessage);
+                return
+            }
             const first_tx = api_result[0];
             if (first_tx) {
                 if (first_tx.version) {

assets_styles_settings.css

@@ -248,7 +248,8 @@ ul.conf_options li .conf_emoji {
 
 .selectbox .options>.optionwrap img.icon {
 	width:2em;
-	margin-right:0.4em;
+	margin-right:0.3em;
+	margin-left:-0.3em;
 	vertical-align: middle;
 }
 
@@ -319,6 +320,33 @@ ul.conf_options li .conf_emoji {
 	opacity: 1;
 }
 
+#settingsbox .optionwrap .cstat {
+	display: inline;
+	border:none;
+	padding: 0;
+	color: rgba(0, 0, 0, 0.5);
+	opacity: 0;
+	transition: opacity 1000ms ease;
+}
+
+#settingsbox .optionwrap.live .cstat {
+	color: #00c000;
+	opacity: 1;
+}
+
+#settingsbox .optionwrap.offline .cstat {
+	color: #FF0000;
+	opacity: 1;
+}
+
+#settingsbox .optionwrap .v {
+	display: inline;
+	border: none;
+	padding: 0;
+	font-size: 75%;
+	color: #959595;
+}
+
 #settingsbox #rpc_input_box #rpc_username_input,
 #settingsbox #rpc_input_box #rpc_password_input {
 	display: none;