bip39 checks

Author: bitrequest

assets_js_bitrequest_bip39.js

@@ -147,24 +147,22 @@ function bipv_pass() {
 function test_bip39() {
     if (!crypto) { // test for window.crypto
         bip39_fail();
-        glob_let.test_derive = false;
         return
     }
     if (glob_const.has_bigint === false) { // test for js BigInt
         bip39_fail();
-        glob_let.test_derive = false;
         return
     }
     const k_str = glob_const.expected_seed.slice(0, 32),
         enc_test = aes_enc(glob_const.test_phrase, k_str),
         dec_test = aes_dec(enc_test, k_str);
     if (glob_const.test_phrase !== dec_test) { // test encryption
         bip39_fail();
-        glob_let.test_derive = false;
         return
     }
     if (toseed(glob_const.test_phrase) !== glob_const.expected_seed || test_derivation() === false) {
-        const coinsToDeriveFailure = ["bitcoin", "litecoin", "dogecoin", "dash", "ethereum", "bitcoin-cash"];
+        bip39_fail();
+        const coinsToDeriveFailure = ["bitcoin", "litecoin", "dogecoin", "dash", "ethereum", "bitcoin-cash", "monero", "nano"];
         derive_fail(coinsToDeriveFailure);
         coinsToDeriveFailure.forEach(coin => {
             glob_const.c_derive[coin] = false;
@@ -174,6 +172,10 @@ function test_bip39() {
             "check": bech32_check,
             "coin": "bitcoin"
         },
+        {
+            "check": bech32_check,
+            "coin": "litecoin"
+        },
         {
             "check": cashaddr_check,
             "coin": "bitcoin-cash"
@@ -187,10 +189,10 @@ function test_bip39() {
             "coin": "monero"
         }
     ];
-    derivationChecks.forEach(({
+    derivationChecks.forEach(function({
         check,
         coin
-    }) => {
+    }) {
         if (check() === false) {
             derive_fail([coin]);
             glob_const.c_derive[coin] = false;
@@ -213,6 +215,7 @@ function test_bip39() {
 // Handles BIP39 failure by adding a CSS class
 function bip39_fail() {
     glob_const.body.addClass("nobip");
+    glob_let.test_derive = false;
 }
 
 // Handles derivation failure for specified cryptocurrencies
@@ -237,71 +240,106 @@ function derive_xpub_fail(arr) {
 
 // Tests derivation process for Bitcoin
 function test_derivation() {
-    const currency = "bitcoin",
-        test_rootkey = get_rootkey(glob_const.expected_seed),
-        bip32dat = getbip32dat(currency),
-        dx_dat = {
-            "dpath": "m/44'/0'/0'/0/0",
-            "key": test_rootkey.slice(0, 64),
-            "cc": test_rootkey.slice(64)
-        },
-        x_keys_dat = derive_x(dx_dat),
-        key_object = format_keys(glob_const.expected_seed, x_keys_dat, bip32dat, 0, currency);
-    return key_object.address === glob_const.expected_address;
+    try {
+        const currency = "bitcoin",
+            test_rootkey = get_rootkey(glob_const.expected_seed),
+            bip32dat = getbip32dat(currency),
+            dx_dat = {
+                "dpath": "m/44'/0'/0'/0/0",
+                "key": test_rootkey.slice(0, 64),
+                "cc": test_rootkey.slice(64)
+            },
+            x_keys_dat = derive_x(dx_dat),
+            key_object = format_keys(glob_const.expected_seed, x_keys_dat, bip32dat, 0, currency);
+        return key_object.address === glob_const.expected_address;
+    } catch (e) {
+        console.error(e.name, e.message);
+        return false;
+    }
 }
 
 // Checks Bech32 address derivation
 function bech32_check() {
-    const bip84_pub = "03bb4a626f63436a64d7cf1e441713cc964c0d53289a5b17acb1b9c262be57cb17",
-        bip84_bech32 = pub_to_address_bech32("bc", bip84_pub);
-    return glob_const.expected_bech32 === bip84_bech32;
+    try {
+        const bip84_pub = "03bb4a626f63436a64d7cf1e441713cc964c0d53289a5b17acb1b9c262be57cb17",
+            bip84_bech32 = pub_to_address_bech32("bc", bip84_pub);
+        return glob_const.expected_bech32 === bip84_bech32;
+    } catch (e) {
+        console.error(e.name, e.message);
+        return false;
+    }
 }
 
 // Checks Bitcoin Cash cashaddr derivation
 function cashaddr_check() {
-    const bch_legacy = "1AVPurYZinnctgGPiXziwU6PuyZKX5rYZU",
-        bch_cashaddr = pub_to_cashaddr(bch_legacy);
-    return glob_const.expected_bch_cashaddr === bch_cashaddr;
+    try {
+        const bch_legacy = "1AVPurYZinnctgGPiXziwU6PuyZKX5rYZU",
+            bch_cashaddr = pub_to_cashaddr(bch_legacy);
+        return glob_const.expected_bch_cashaddr === bch_cashaddr;
+    } catch (e) {
+        console.error(e.name, e.message);
+        return false;
+    }
 }
 
 // Checks Nano address derivation
 function nano_check() {
-    const expected_nano_address = "nano_1mbtirc4x3kixfy5wufxaqakd3gbojpn6gpmk6kjiyngnjwgy6yty3txgztq",
-        xnano_address = NanocurrencyWeb.wallet.accounts(glob_const.expected_seed, 0, 0)[0].address;
-    return expected_nano_address === xnano_address;
+    try {
+        const expected_nano_address = "nano_1mbtirc4x3kixfy5wufxaqakd3gbojpn6gpmk6kjiyngnjwgy6yty3txgztq",
+            xnano_address = NanocurrencyWeb.wallet.accounts(glob_const.expected_seed, 0, 0)[0].address;
+        return expected_nano_address === xnano_address;
+    } catch (e) {
+        console.error(e.name, e.message);
+        return false;
+    }
 }
 
 // Checks Monero (XMR) address derivation
 function xmr_check() { // https://coinomi.github.io/tools/bip39/
-    const expected_xmr_address = "477h3C6E6C4VLMR36bQL3yLcA8Aq3jts1AHLzm5QXipDdXVCYPnKEvUKykh2GTYqkkeQoTEhWpzvVQ4rMgLM1YpeD6qdHbS",
-        ssk = get_ssk(glob_const.expected_seed, true),
-        xko = xmr_getpubs(ssk, 0);
-    return xko.address === expected_xmr_address;
+    try {
+        const expected_xmr_address = "477h3C6E6C4VLMR36bQL3yLcA8Aq3jts1AHLzm5QXipDdXVCYPnKEvUKykh2GTYqkkeQoTEhWpzvVQ4rMgLM1YpeD6qdHbS",
+            ssk = get_ssk(glob_const.expected_seed, true),
+            xko = xmr_getpubs(ssk, 0);
+        return xko.address === expected_xmr_address;
+    } catch (e) {
+        console.error(e.name, e.message);
+        return false;
+    }
 }
 
 // Checks extended public key (xpub) derivation for Bitcoin
 function xpub_check() {
-    const currency = "bitcoin",
-        xpub_keycc = key_cc_xpub("xpub6Cy7dUR4ZKF22HEuVq7epRgRsoXfL2MK1RE81CSvp1ZySySoYGXk5PUY9y9Cc5ExpnSwXyimQAsVhyyPDNDrfj4xjDsKZJNYgsHXoEPNCYQ"),
-        dx_dat = {
-            "dpath": "M/0/0",
-            "key": xpub_keycc.key,
-            "cc": xpub_keycc.cc,
-            "vb": xpub_keycc.version
-        },
-        x_keys_dat = derive_x(dx_dat),
-        bip32dat = getbip32dat(currency),
-        key_object = format_keys(null, x_keys_dat, bip32dat, 0, currency),
-        xpub_address = key_object.address,
-        xpub_wildcard_address = "bc1qk0wlvl4xh3eqe5szqyrlcj4ws8633vz0vhhywl"; // wildcard for bech32 Xpubs (Zpub)
-    return xpub_address === glob_const.expected_address || xpub_address === xpub_wildcard_address;
+    try {
+        const currency = "bitcoin",
+            xpub_keycc = key_cc_xpub("xpub6Cy7dUR4ZKF22HEuVq7epRgRsoXfL2MK1RE81CSvp1ZySySoYGXk5PUY9y9Cc5ExpnSwXyimQAsVhyyPDNDrfj4xjDsKZJNYgsHXoEPNCYQ"),
+            dx_dat = {
+                "dpath": "M/0/0",
+                "key": xpub_keycc.key,
+                "cc": xpub_keycc.cc,
+                "vb": xpub_keycc.version
+            },
+            x_keys_dat = derive_x(dx_dat),
+            bip32dat = getbip32dat(currency),
+            key_object = format_keys(null, x_keys_dat, bip32dat, 0, currency),
+            xpub_address = key_object.address,
+            xpub_wildcard_address = "bc1qk0wlvl4xh3eqe5szqyrlcj4ws8633vz0vhhywl"; // wildcard for bech32 Xpubs (Zpub)
+        return xpub_address === glob_const.expected_address || xpub_address === xpub_wildcard_address;
+    } catch (e) {
+        console.error(e.name, e.message);
+        return false;
+    }
 }
 
 // Checks Ethereum extended public key (xpub) derivation
 function eth_xpub_check() {
-    const eth_pub = "03c026c4b041059c84a187252682b6f80cbbe64eb81497111ab6914b050a8936fd",
-        eth_address = pub_to_eth_address(eth_pub);
-    return glob_const.expected_eth_address === eth_address;
+    try {
+        const eth_pub = "03c026c4b041059c84a187252682b6f80cbbe64eb81497111ab6914b050a8936fd",
+            eth_address = pub_to_eth_address(eth_pub);
+        return glob_const.expected_eth_address === eth_address;
+    } catch (e) {
+        console.error(e.name, e.message);
+        return false;
+    }
 }
 
 // Check derivations
@@ -1757,9 +1795,9 @@ function phrase_info_pu(coin) {
             if (glob_const.c_derive[currency]) {
                 $("#pi_icons").append(icon_node);
                 $("#d_paths").append(dp_node);
+                $("#xpub_box").append(xp_node);
+                $("#segw_box").append(segw_node);
             }
-            $("#xpub_box").append(xp_node);
-            $("#segw_box").append(segw_node);
             $("#supported_wallets").append(sw_node);
             pi_show();
         }

assets_js_bitrequest_coin_settings.js

@@ -615,8 +615,8 @@ function test_rpc(rpc_input_box, rpc_data, currency) {
         const rpcurl = get_rpc_url(rpc_data),
             testadress = {
                 "bitcoin": glob_const.expected_bech32,
-                "litecoin": glob_const.expected_ltc_address,
-                "dogecoin": glob_const.expected_doge_address,
+                "litecoin": "LZakyXotaE29Pehw21SoPuU832UhvJp4LG",
+                "dogecoin": "DKvWg8UhQSycj1J8QVxeBDkRpbjDkw3DiW",
                 "bitcoin-cash": glob_const.expected_bch_cashaddr
             } [currency] || "",
             pload = glob_let.is_btc ? {

assets_js_bitrequest_core.js

@@ -2629,7 +2629,7 @@ function canceldialogtrigger() {
 
 // Closes the current dialog
 function canceldialog(pass) {
-    if (glob_const.inframe === true) {
+    if (glob_const.inframe) {
         if (pass !== true) {
             if ($("#contactformbox").length > 0) {
                 return
@@ -5220,7 +5220,6 @@ function handleAddress(result, payment) {
         isxpub = (end_result.length > 103),
         er_val = (payment === "nimiq") ? end_result.replace(/\s/g, "") : end_result,
         validate = isxpub ? check_xpub(end_result, xpub_prefix(payment), payment) : check_address(er_val, payment);
-
     clear_xpub_inputs();
     if (validate === true) {
         $("#popup .formbox input.address").val(er_val);

assets_js_bitrequest_settings.js

@@ -924,7 +924,7 @@ function complilebackup() {
             continue;
         } else if (key === "bitrequest_bpdat") {
             const not_verified = (glob_let.io.bipv !== "yes");
-            if (not_verified || (glob_let.test_derive === true && get_setting("backup", "sbu") === true)) {
+            if (not_verified || (glob_let.test_derive && get_setting("backup", "sbu") === true)) {
                 const val_obj = JSON.parse(value);
                 val_obj.dat = null;
                 jsonfile.push('"' + key + '":' + JSON.stringify(val_obj));
@@ -1605,7 +1605,7 @@ function compare_seeds_callback(compare) {
 function restorestorage(jsonobject, newphrase) {
     $.each(jsonobject, function(key, value) {
         if (key === "bitrequest_bpdat") {
-            if (glob_let.test_derive === true && newphrase === true && glob_let.resd.bpdat) {
+            if (glob_let.test_derive && newphrase === true && glob_let.resd.bpdat) {
                 localStorage.setItem(key, JSON.stringify(glob_let.resd.bpdat));
             }
         } else {

assets_js_lib_global_queries.js

@@ -33,10 +33,6 @@ const br_bipobj = br_get_local("bpdat", true),
     (br_thishostname === br_thishostname) ? "selfhosted" : "unknown",
     br_video = $("#qr-video")[0],
     glob_const = {
-        "default_error": {
-            "error": "no transactions found",
-            "console": true
-        },
         "stored_currencies": br_get_local("currencies", true),
         "apptitle": "Bitrequest",
         "hostname": br_hostname,
@@ -125,14 +121,12 @@ const br_bipobj = br_get_local("bpdat", true),
                 "seed": true
             }
         },
-        // bip39
+        // bip39 (All addresses / xpubs in this app are test addresses derived from the following testphrase, taken from https://github.com/bitcoinbook/bitcoinbook/blob/f8b883dcd4e3d1b9adf40fed59b7e898fbd9241f/ch05.asciidoc)
         "test_phrase": "army van defense carry jealous true garbage claim echo media make crunch", // random phrase used for test derive
         "expected_seed": "5b56c417303faa3fcba7e57400e120a0ca83ec5a4fc9ffba757fbe63fbd77a89a1a3be4c67196f57c39a88b76373733891bfaba16ed27a813ceed498804c0570", // expected seed used for test derive
         "expected_address": "1HQ3rb7nyLPrjnuW85MUknPekwkn7poAUm", // expected addres used for test derive
         "expected_bech32": "bc1qg0azlj4w2lrq8jssrrz6eprt2fe7f7edm4vpd5", // expected bech32 addres used for test derive
-        "expected_ltc_address": "LZakyXotaE29Pehw21SoPuU832UhvJp4LG",
         "expected_bch_cashaddr": "qp5p0eur784pk8wxy2kzlz3ctnq5whfnuqqpp78u22",
-        "expected_doge_address": "DKvWg8UhQSycj1J8QVxeBDkRpbjDkw3DiW",
         "expected_eth_address": "0x2161DedC3Be05B7Bb5aa16154BcbD254E9e9eb68",
         "c_derive": {
             "bitcoin": true,

assets_styles_styles.css

@@ -51,6 +51,7 @@ body.nobip #bip39_passphrase,
 body.nobip .cc_settinglist li[data-id='Xpub'],
 body.nobip .cc_settinglist li[data-id='Key derivations'],
 .no_derive .cc_settinglist li[data-id='Key derivations'],
+.no_derive .cc_settinglist li[data-id='Xpub'],
 .no_xpub .cc_settinglist li[data-id='Xpub'],
 body.nobip .cc_settinglist li[data-id='Reuse address'],
 .no_derive .cc_settinglist li[data-id='Reuse address'],