Add Interceptor Unit Tests

Author: navarr

tests/bitExpert/PHPStan/Magento/Autoload/Helper.php

@@ -0,0 +1,20 @@
+<?php
+
+/*
+ * This file is part of the phpstan-magento package.
+ *
+ * (c) bitExpert AG
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+declare(strict_types=1);
+
+namespace bitExpert\PHPStan\Magento\Autoload;
+
+/**
+ * Dummy class that can be loaded via the Autoloader in the test cases.
+ */
+class Helper
+{
+}

tests/bitExpert/PHPStan/Magento/Autoload/HelperInterceptor.php

@@ -0,0 +1,20 @@
+<?php
+
+/*
+ * This file is part of the phpstan-magento package.
+ *
+ * (c) bitExpert AG
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+declare(strict_types=1);
+
+namespace bitExpert\PHPStan\Magento\Autoload;
+
+/**
+ * Dummy class that can be loaded via the Autoloader in the test cases.
+ */
+class HelperInterceptor
+{
+}

tests/bitExpert/PHPStan/Magento/Autoload/InterceptorAutoloaderUnitTest.php

@@ -0,0 +1,99 @@
+<?php
+
+/*
+ * This file is part of the phpstan-magento package.
+ *
+ * (c) bitExpert AG
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+declare(strict_types=1);
+
+namespace bitExpert\PHPStan\Magento\Autoload;
+
+use bitExpert\PHPStan\Magento\Autoload\DataProvider\ClassLoaderProvider;
+use PHPStan\Cache\Cache;
+use PHPStan\Cache\CacheStorage;
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+
+class InterceptorAutoloaderUnitTest extends TestCase
+{
+    private CacheStorage&MockObject $storage;
+    private ClassLoaderProvider&MockObject $classLoader;
+    private InterceptorAutoloader $autoloader;
+
+    public function setUp(): void
+    {
+        $this->storage = $this->createMock(CacheStorage::class);
+        $this->classLoader = $this->createMock(ClassLoaderProvider::class);
+
+        $this->autoloader = new InterceptorAutoloader(new Cache($this->storage), $this->classLoader);
+    }
+
+    /**
+     * @test
+     */
+    public function autoloaderIgnoresClassesWithoutInterceptorPostfix(): void
+    {
+        $this->classLoader->expects(self::never())
+            ->method('findFile');
+        $this->storage->expects(self::never())
+            ->method('load');
+
+        $this->autoloader->autoload('SomeClass');
+    }
+
+    /**
+     * @test
+     */
+    public function autoloaderPrefersLocalFile(): void
+    {
+        $this->classLoader->expects(self::once())
+            ->method('findFile')
+            ->willReturn(__DIR__ . '/HelperInterceptor.php');
+        $this->storage->expects(self::never())
+            ->method('load');
+
+        $this->autoloader->autoload('\bitExpert\PHPStan\Magento\Autoload\Helper\Interceptor');
+
+        self::assertTrue(class_exists(HelperInterceptor::class, false));
+    }
+
+    /**
+     * @test
+     */
+    public function autoloaderUsesCachedFileWhenFound(): void
+    {
+        $this->classLoader->expects(self::once())
+            ->method('findFile')
+            ->willReturn(false);
+        $this->storage->expects(self::once())
+            ->method('load')
+            ->willReturn(__DIR__ . '/HelperInterceptor.php');
+
+        $this->autoloader->autoload('\bitExpert\PHPStan\Magento\Autoload\Helper\Interceptor');
+
+        self::assertTrue(class_exists(HelperInterceptor::class, false));
+    }
+
+    /**
+     * @test
+     */
+    public function autoloaderGeneratesCacheFileWhenNotFoundInCache(): void
+    {
+        $this->classLoader->expects(self::once())
+            ->method('findFile')
+            ->willReturn(false);
+        $this->storage->expects(self::atMost(2))
+            ->method('load')
+            ->willReturnOnConsecutiveCalls(null, __DIR__ . '/HelperInterceptor.php');
+        $this->storage->expects(self::once())
+            ->method('save');
+
+        $this->autoloader->autoload('\bitExpert\PHPStan\Magento\Autoload\Helper\Interceptor');
+
+        self::assertTrue(class_exists(HelperInterceptor::class, false));
+    }
+}

tests/bitExpert/PHPStan/Magento/Autoload/ProxyAutoloaderUnitTest.php

@@ -91,10 +91,6 @@ public function autoloaderUsesCachedFileWhenFound(): void
      */
     public function autoloaderGeneratesCacheFileWhenNotFoundInCache(): void
     {
-        // little hack: the proxy autoloader will use Reflection to look for a class without the \Proxy prefix,
-        // to avoid having another stub class file, we define an class alias here
-        class_alias('\bitExpert\PHPStan\Magento\Autoload\HelperProxy', '\bitExpert\PHPStan\Magento\Autoload\Helper');
-
         $this->classLoader->expects(self::once())
             ->method('findFile')
             ->willReturn(false);