Skip to content

Commit 7914528

Browse files
authored
Changed pull_request_target to pull_request (#625)
### Changes 1. Change pull_request_target to pull_request for better security. 2. Remove the authorize job from the list of jobs defined in that workflow. 3. Remove the dependency on authorize job for other jobs in that workflow by looking for the line needs: authorize. ### Checklist - [ ] I have read the [Auth0 general contribution guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md) - [ ] I have read the [Auth0 Code of Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md) - [ ] All existing and new tests complete without errors
2 parents b9277de + a25e94c commit 7914528

File tree

3 files changed

+3
-30
lines changed

3 files changed

+3
-30
lines changed

.github/workflows/semgrep.yml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Semgrep
22

33
on:
44
merge_group:
5-
pull_request_target:
5+
pull_request:
66
types:
77
- opened
88
- synchronize
@@ -20,16 +20,7 @@ concurrency:
2020
cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}
2121

2222
jobs:
23-
authorize:
24-
name: Authorize
25-
environment: ${{ github.actor != 'dependabot[bot]' && github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != github.repository && 'external' || 'internal' }}
26-
runs-on: ubuntu-latest
27-
steps:
28-
- run: true
29-
3023
run:
31-
needs: authorize # Require approval before running on forked pull requests
32-
3324
name: Check for Vulnerabilities
3425
runs-on: ubuntu-latest
3526

.github/workflows/snyk.yml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Snyk
22

33
on:
44
merge_group:
5-
pull_request_target:
5+
pull_request:
66
types:
77
- opened
88
- synchronize
@@ -22,16 +22,7 @@ concurrency:
2222
cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}
2323

2424
jobs:
25-
authorize:
26-
name: Authorize
27-
environment: ${{ github.actor != 'dependabot[bot]' && github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != github.repository && 'external' || 'internal' }}
28-
runs-on: ubuntu-latest
29-
steps:
30-
- run: true
31-
3225
check:
33-
needs: authorize
34-
3526
name: Check for Vulnerabilities
3627
runs-on: ubuntu-latest
3728

.github/workflows/test.yml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Build and Test
22

33
on:
44
merge_group:
5-
pull_request_target:
5+
pull_request:
66
types:
77
- opened
88
- synchronize
@@ -18,16 +18,7 @@ concurrency:
1818
cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}
1919

2020
jobs:
21-
authorize:
22-
name: Authorize
23-
environment: ${{ github.actor != 'dependabot[bot]' && github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != github.repository && 'external' || 'internal' }}
24-
runs-on: ubuntu-latest
25-
steps:
26-
- run: true
27-
2821
run:
29-
needs: authorize # Require approval before running on forked pull requests
30-
3122
name: Run
3223
runs-on: ubuntu-latest
3324

0 commit comments

Comments
 (0)