Send $/start notification to the serial client upon startup.

Author: cmaglie

internal/msgpackrouter/router.go

@@ -56,9 +56,17 @@ func (r *Router) SetSendMaxWorkers(size int) {
 }
 
 func (r *Router) Accept(conn io.ReadWriteCloser) <-chan struct{} {
+	return r.accept(conn, false)
+}
+
+func (r *Router) AcceptAndSendNotification(conn io.ReadWriteCloser) <-chan struct{} {
+	return r.accept(conn, true)
+}
+
+func (r *Router) accept(conn io.ReadWriteCloser, sendStartNotification bool) <-chan struct{} {
 	res := make(chan struct{})
 	go func() {
-		r.connectionLoop(conn)
+		r.connectionLoop(conn, sendStartNotification)
 		close(res)
 	}()
 	return res
@@ -79,7 +87,7 @@ func (r *Router) RegisterMethod(method string, handler RouterRequestHandler) err
 	return nil
 }
 
-func (r *Router) connectionLoop(conn io.ReadWriteCloser) {
+func (r *Router) connectionLoop(conn io.ReadWriteCloser, sendStartNotification bool) {
 	defer conn.Close()
 
 	var msgpackconn *msgpackrpc.Connection
@@ -172,6 +180,14 @@ func (r *Router) connectionLoop(conn io.ReadWriteCloser) {
 		r.sendMaxWorkers,
 	)
 
+	if sendStartNotification {
+		// Send the start notification to the client
+		if err := msgpackconn.SendNotification("$/start"); err != nil {
+			slog.Error("Failed to send $/start notification", "err", err)
+			return
+		}
+	}
+
 	msgpackconn.Run()
 
 	// Unregister the methods when the connection is terminated

main.go

@@ -251,7 +251,7 @@ func startRouter(cfg Config) error {
 				wr := &MsgpackDebugStream{Name: cfg.SerialPortAddr, Upstream: serialPort}
 
 				// wait for the close command from RPC or for a failure of the serial port (routerExit)
-				routerExit := router.Accept(wr)
+				routerExit := router.AcceptAndSendNotification(wr)
 				select {
 				case <-routerExit:
 					slog.Info("Serial port failed connection")