code review fix

mirkoCrobu · mirkoCrobu · commit c9951cba5e98 · 2025-12-16T11:38:29.000+01:00
diff --git a/pkg/board/os_image.go b/pkg/board/os_image.go
@@ -53,7 +53,7 @@ func parseOSImageVersion(r io.Reader) (string, bool) {
 			continue
 		}
 
-		version := strings.Trim(value, `"' `)
+		version := strings.TrimSpace(value)
 		if version != "" {
 			return version, true
 		}
diff --git a/pkg/board/os_image_test.go b/pkg/board/os_image_test.go
@@ -77,7 +77,7 @@ func TestParseOSImageVersion(t *testing.T) {
 	}{
 		{
 			name:     "valid build id",
-			input:    "BUILD_ID=\"20251006-395\"\nVARIANT_ID=xfce",
+			input:    "BUILD_ID=20251006-395\nVARIANT_ID=xfce",
 			expected: "20251006-395",
 			found:    true,
 		},

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ func parseOSImageVersion(r io.Reader) (string, bool) {`
`53`	`53`	`continue`
`54`	`54`	`}`
`55`	`55`
`56`		- version := strings.Trim(value, `"' `)
	`56`	`+ version := strings.TrimSpace(value)`
`57`	`57`	`if version != "" {`
`58`	`58`	`return version, true`
`59`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ func TestParseOSImageVersion(t *testing.T) {`
`77`	`77`	`}{`
`78`	`78`	`{`
`79`	`79`	`name: "valid build id",`
`80`		`- input: "BUILD_ID=\"20251006-395\"\nVARIANT_ID=xfce",`
	`80`	`+ input: "BUILD_ID=20251006-395\nVARIANT_ID=xfce",`
`81`	`81`	`expected: "20251006-395",`
`82`	`82`	`found: true,`
`83`	`83`	`},`