Skip to content

Commit 5f657cc

Browse files
committed
Address comments
1 parent a79df4b commit 5f657cc

File tree

2 files changed

+24
-15
lines changed

2 files changed

+24
-15
lines changed

src/main/java/io/appium/java_client/proxy/Helpers.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,12 @@
3131
import org.openqa.selenium.remote.RemoteWebElement;
3232

3333
import java.lang.reflect.Method;
34-
import java.util.*;
34+
import java.util.Collection;
35+
import java.util.Collections;
36+
import java.util.List;
37+
import java.util.Map;
38+
import java.util.Set;
39+
import java.util.WeakHashMap;
3540
import java.util.stream.Collectors;
3641
import java.util.stream.Stream;
3742

src/main/java/io/appium/java_client/proxy/Interceptor.java

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
import org.slf4j.LoggerFactory;
2727

2828
import java.lang.reflect.Method;
29-
import java.util.ArrayList;
3029
import java.util.List;
3130
import java.util.concurrent.Callable;
31+
import java.util.stream.Collectors;
3232

3333
import static io.appium.java_client.proxy.MethodCallListener.UNSET;
3434

@@ -115,21 +115,25 @@ public static Object intercept(
115115
}
116116

117117
if (result instanceof RemoteWebElement) {
118-
result = Helpers.wrapElement((RemoteWebElement) result, (HasMethodCallListeners) self, listeners);
118+
result = Helpers.wrapElement(
119+
(RemoteWebElement) result,
120+
(HasMethodCallListeners) self,
121+
listeners);
119122
} else if (result instanceof List) {
120123
List<?> originalList = (List<?>) result;
121-
if (!originalList.isEmpty() && originalList.get(0) instanceof RemoteWebElement) {
122-
List<Object> wrappedList = new ArrayList<>(originalList.size());
123-
for (Object item : originalList) {
124-
if (item instanceof RemoteWebElement) {
125-
wrappedList.add(Helpers.wrapElement(
126-
(RemoteWebElement) item,
127-
(HasMethodCallListeners) self, listeners));
128-
} else {
129-
wrappedList.add(item);
130-
}
131-
}
132-
result = wrappedList;
124+
125+
if (!originalList.isEmpty()) {
126+
result = originalList.stream()
127+
.map(item -> {
128+
if (item instanceof RemoteWebElement) {
129+
return Helpers.wrapElement(
130+
(RemoteWebElement) item,
131+
(HasMethodCallListeners) self,
132+
listeners);
133+
}
134+
return item;
135+
})
136+
.collect(Collectors.toList());
133137
}
134138
}
135139

0 commit comments

Comments
 (0)