Skip to content

Commit 13f7e29

Browse files
CR fixes 2
1 parent 8040a15 commit 13f7e29

File tree

6 files changed

+19
-15
lines changed

6 files changed

+19
-15
lines changed

src/e2eFlutterTest/java/io/appium/java_client/android/BaseFlutterTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
import io.appium.java_client.AppiumBy;
44
import io.appium.java_client.android.options.UiAutomator2Options;
5-
import io.appium.java_client.flutter.FlutterDriver;
65
import io.appium.java_client.flutter.FlutterDriverOptions;
6+
import io.appium.java_client.flutter.FlutterIntegrationTestDriver;
77
import io.appium.java_client.flutter.android.FlutterAndroidDriver;
88
import io.appium.java_client.flutter.commands.ScrollParameter;
99
import io.appium.java_client.flutter.ios.FlutterIOSDriver;
@@ -32,7 +32,7 @@ class BaseFlutterTest {
3232
protected static final int PORT = 4723;
3333

3434
private static AppiumDriverLocalService service;
35-
protected static FlutterDriver driver;
35+
protected static FlutterIntegrationTestDriver driver;
3636
protected static final By LOGIN_BUTTON = AppiumBy.flutterText("Login");
3737

3838
/**

src/main/java/io/appium/java_client/flutter/FlutterDriverOptions.java

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,28 +20,32 @@ public class FlutterDriverOptions extends BaseOptions<FlutterDriverOptions> impl
2020
SupportsFlutterElementWaitTimeoutOption<FlutterDriverOptions> {
2121

2222
public FlutterDriverOptions() {
23-
setCommonOptions();
23+
setDefaultOptions();
2424
}
2525

2626
public FlutterDriverOptions(Capabilities source) {
2727
super(source);
28-
setCommonOptions();
28+
setDefaultOptions();
2929
}
3030

3131
public FlutterDriverOptions(Map<String, ?> source) {
3232
super(source);
33-
setCommonOptions();
33+
setDefaultOptions();
3434
}
3535

3636
public FlutterDriverOptions setUiAutomator2Options(UiAutomator2Options uiAutomator2Options) {
37-
return merge(uiAutomator2Options);
37+
return setDefaultOptions(merge(uiAutomator2Options));
3838
}
3939

4040
public FlutterDriverOptions setXCUITestOptions(XCUITestOptions xcuiTestOptions) {
41-
return merge(xcuiTestOptions);
41+
return setDefaultOptions(merge(xcuiTestOptions));
4242
}
4343

44-
private void setCommonOptions() {
45-
setAutomationName(AutomationName.FLUTTER_INTEGRATION);
44+
private void setDefaultOptions() {
45+
setDefaultOptions(this);
46+
}
47+
48+
private FlutterDriverOptions setDefaultOptions(FlutterDriverOptions flutterDriverOptions) {
49+
return flutterDriverOptions.setAutomationName(AutomationName.FLUTTER_INTEGRATION);
4650
}
4751
}

src/main/java/io/appium/java_client/flutter/FlutterDriver.java renamed to src/main/java/io/appium/java_client/flutter/FlutterIntegrationTestDriver.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* @see SupportsScrollingOfFlutterElements
1616
* @see SupportsWaitingForFlutterElements
1717
*/
18-
public interface FlutterDriver extends
18+
public interface FlutterIntegrationTestDriver extends
1919
WebDriver,
2020
SupportsGestureOnFlutterElements,
2121
SupportsScrollingOfFlutterElements,

src/main/java/io/appium/java_client/flutter/android/FlutterAndroidDriver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import io.appium.java_client.AppiumClientConfig;
44
import io.appium.java_client.android.AndroidDriver;
5-
import io.appium.java_client.flutter.FlutterDriver;
5+
import io.appium.java_client.flutter.FlutterIntegrationTestDriver;
66
import io.appium.java_client.service.local.AppiumDriverLocalService;
77
import io.appium.java_client.service.local.AppiumServiceBuilder;
88
import org.openqa.selenium.Capabilities;
@@ -15,7 +15,7 @@
1515
/**
1616
* Custom AndroidDriver implementation with additional Flutter-specific capabilities.
1717
*/
18-
public class FlutterAndroidDriver extends AndroidDriver implements FlutterDriver {
18+
public class FlutterAndroidDriver extends AndroidDriver implements FlutterIntegrationTestDriver {
1919

2020
public FlutterAndroidDriver(HttpCommandExecutor executor, Capabilities capabilities) {
2121
super(executor, capabilities);

src/main/java/io/appium/java_client/flutter/ios/FlutterIOSDriver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package io.appium.java_client.flutter.ios;
22

33
import io.appium.java_client.AppiumClientConfig;
4-
import io.appium.java_client.flutter.FlutterDriver;
4+
import io.appium.java_client.flutter.FlutterIntegrationTestDriver;
55
import io.appium.java_client.ios.IOSDriver;
66
import io.appium.java_client.service.local.AppiumDriverLocalService;
77
import io.appium.java_client.service.local.AppiumServiceBuilder;
@@ -15,7 +15,7 @@
1515
/**
1616
* Custom IOSDriver implementation with additional Flutter-specific capabilities.
1717
*/
18-
public class FlutterIOSDriver extends IOSDriver implements FlutterDriver {
18+
public class FlutterIOSDriver extends IOSDriver implements FlutterIntegrationTestDriver {
1919

2020
public FlutterIOSDriver(HttpCommandExecutor executor, Capabilities capabilities) {
2121
super(executor, capabilities);

src/main/java/io/appium/java_client/flutter/options/SupportsFlutterSystemPortOption.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public interface SupportsFlutterSystemPortOption<T extends BaseOptions<T>> exten
1818
* @param flutterSystemPort is the port number
1919
* @return self instance for chaining.
2020
*/
21-
default T setFlutterSystemPort(Integer flutterSystemPort) {
21+
default T setFlutterSystemPort(int flutterSystemPort) {
2222
return amend(FLUTTER_SYSTEM_PORT_OPTION, flutterSystemPort);
2323
}
2424

0 commit comments

Comments
 (0)