From b695f569afead1d56646c3f06b6995c483dcb274 Mon Sep 17 00:00:00 2001 From: James Jurach Date: Fri, 1 Dec 2017 04:09:02 -0800 Subject: [PATCH] move TaskRoleArn out of ContainerDefinitions --- workshop3/hints/final-service.yml | 2 +- workshop3/hints/new-service.yml | 2 +- workshop3/index.html | 2 +- workshop3/readme.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/workshop3/hints/final-service.yml b/workshop3/hints/final-service.yml index 8a73048..23f9cb9 100644 --- a/workshop3/hints/final-service.yml +++ b/workshop3/hints/final-service.yml @@ -70,6 +70,7 @@ Resources: Type: AWS::ECS::TaskDefinition Properties: Family: iridium + TaskRoleArn: !Ref ECSTaskRole ContainerDefinitions: - Name: iridium Image: !Sub ${AWS::AccountId}.dkr.ecr.${AWS::Region}.amazonaws.com/${Repository}:${Tag} @@ -80,7 +81,6 @@ Resources: Environment: - Name: Tag Value: !Ref Tag - TaskRoleArn: !Ref ECSTaskRole LogConfiguration: LogDriver: awslogs Options: diff --git a/workshop3/hints/new-service.yml b/workshop3/hints/new-service.yml index fd851cd..976209e 100644 --- a/workshop3/hints/new-service.yml +++ b/workshop3/hints/new-service.yml @@ -64,6 +64,7 @@ Resources: Type: AWS::ECS::TaskDefinition Properties: Family: iridium + TaskRoleArn: !Ref ECSTaskRole ContainerDefinitions: - Name: iridium Image: !Sub ${AWS::AccountId}.dkr.ecr.${AWS::Region}.amazonaws.com/${Repository}:${Tag} @@ -74,7 +75,6 @@ Resources: Environment: - Name: Tag Value: !Ref Tag - TaskRoleArn: !Ref ECSTaskRole LogConfiguration: LogDriver: awslogs Options: diff --git a/workshop3/index.html b/workshop3/index.html index 70aae3d..ee0a1c4 100644 --- a/workshop3/index.html +++ b/workshop3/index.html @@ -944,6 +944,7 @@ Type: AWS::ECS::TaskDefinition Properties: Family: iridium + TaskRoleArn: !Ref ECSTaskRole ContainerDefinitions: - Name: iridium Image: !Sub ${AWS::AccountId}.dkr.ecr.${AWS::Region}.amazonaws.com/${Repository}:${Tag} @@ -954,7 +955,6 @@ Environment: - Name: Tag Value: !Ref Tag - TaskRoleArn: !Ref ECSTaskRole LogConfiguration: LogDriver: awslogs Options: diff --git a/workshop3/readme.md b/workshop3/readme.md index 55694f9..8c82e86 100644 --- a/workshop3/readme.md +++ b/workshop3/readme.md @@ -934,6 +934,7 @@ TaskDefinition: Type: AWS::ECS::TaskDefinition Properties: Family: iridium + TaskRoleArn: !Ref ECSTaskRole ContainerDefinitions: - Name: iridium Image: !Sub ${AWS::AccountId}.dkr.ecr.${AWS::Region}.amazonaws.com/${Repository}:${Tag} @@ -944,7 +945,6 @@ TaskDefinition: Environment: - Name: Tag Value: !Ref Tag - TaskRoleArn: !Ref ECSTaskRole LogConfiguration: LogDriver: awslogs Options: