Analysis loop in golang binary

[emesare]

This is a regression from 5.0, happens on 5.1 stable and latest dev.

inertial hill injects quickly (password: infected)

Once analysis finally realizes its in a loop:

[Function] Skipping analysis for function at 0x441fc0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x43e2c0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x443820 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x464c80 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x41c120 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x4261e0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x525ac0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x560e20 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x436500 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x52d5e0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x53cbc0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x424820 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x53d740 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x41a580 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x405e00 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x406bc0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x43ca80 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x41e0a0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x43b000 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x4401e0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x4402c0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x440d80 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x440e00 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x440ec0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x4aaa40 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x4ac5a0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x561420 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x562680 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x568440 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x569820 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x56bc80 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x56d340 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x56eda0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x56f320 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x56f940 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x567d80 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x56b4e0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Function] Skipping analysis for function at 0x44d9c0 : Exceeds 'analysis.limits.maxFunctionUpdateCount'. If possible, please report this issue.
[Analysis] Analysis update took 384.554 seconds

This is a regression.

5.0 took ~50 seconds to analyze the binary.

[bpotchik]

[emesare]

@bpotchik inertial hill injects quickly I dont know why that was deleted :/

EDIT: Swapped it to a zip

[bpotchik]

Malware? Deleted again.

[bpotchik]

Thanks I'll take a look. At first glance appears to be non-convergence of parameter resolution.

[bpotchik]

Updated status in slack. Regression from commit https://github.com/Vector35/binaryninja/commit/18cbf798a89e65b427cc991e0eb2733bff1083ec