-
Notifications
You must be signed in to change notification settings - Fork 245
Description
What is the feature you'd like to have?
The demangler demangle callback, if possible, should provide an address of the mangled symbol that it is being asked to demangle.
Is your feature request related to a problem?
In the case of data variables, there are situations where providing an accurate type requires understanding more about the data at that location as things like flags can indicate differences in the structure of the data. Having the address of the symbol allows for a demangler to read the data at the location of the symbol and determine the exact type.
Are any alternative solutions acceptable?
The symbol added callback could be used to do more advanced processing of data variables with mangled symbol names. This might even be a more preferred solution for this kind of problem, given that I think the demangler is more geared towards mangled function names.
Additional Information:
I'm not sure how the demangling works under the hood, I just assume when a symbol is being added it is checked by Binary Ninja to see if a demangler can demangle it, therefore I assume in pretty much all cases the address of the symbol could be provided. If not then the field could be made to be an optional to indicate whether an address has been provided or not.