Merge pull request #35 from ShawnLaMountain/main

Added getter and setter to the Attributes in Source Generator

Author: ShawnLaMountain

.github/workflows/CD.yml

@@ -61,14 +61,14 @@ jobs:
       shell: pwsh
 
     - name: Create NuGet Package
-      # run: nuget pack ThunderDesign.Net-PCL.nuspec -Version 1.1.4 -OutputDirectory ${{ env.PACKAGE_OUTPUT_DIRECTORY }}
+      # run: nuget pack ThunderDesign.Net-PCL.nuspec -Version 2.0.17 -OutputDirectory ${{ env.PACKAGE_OUTPUT_DIRECTORY }}
       run: nuget pack ThunderDesign.Net-PCL.nuspec -Version ${{ github.event.release.tag_name }} -OutputDirectory ${{ env.PACKAGE_OUTPUT_DIRECTORY }}
 
     - name: Archive NuGet Package
       uses: actions/upload-artifact@v4
       with:
-        # name: Package_${{ env.FILE_NAME}}.1.1.4
-        # path: ${{ env.PACKAGE_OUTPUT_DIRECTORY}}\${{ env.FILE_NAME}}.1.1.4.nupkg
+        # name: Package_${{ env.FILE_NAME}}.2.0.17
+        # path: ${{ env.PACKAGE_OUTPUT_DIRECTORY}}\${{ env.FILE_NAME}}.2.0.17.nupkg
         name: Package_${{ env.FILE_NAME}}.${{ github.event.release.tag_name }}
         path: ${{ env.PACKAGE_OUTPUT_DIRECTORY}}\${{ env.FILE_NAME}}.${{ github.event.release.tag_name }}.nupkg
 

README.md

@@ -1,4 +1,4 @@
-# ThunderDesign.Net-PCL.Threading
+# ThunderDesign.Net-PCL.Threading
 [![CI](https://github.com/ThunderDesign/ThunderDesign.Net-PCL.Threading/actions/workflows/CI.yml/badge.svg)](https://github.com/ThunderDesign/ThunderDesign.Net-PCL.Threading/actions/workflows/CI.yml)
 [![CD](https://github.com/ThunderDesign/ThunderDesign.Net-PCL.Threading/actions/workflows/CD.yml/badge.svg)](https://github.com/ThunderDesign/ThunderDesign.Net-PCL.Threading/actions/workflows/CD.yml)
 [![Nuget](https://img.shields.io/nuget/v/ThunderDesign.Net-PCL.Threading)](https://www.nuget.org/packages/ThunderDesign.Net-PCL.Threading)
@@ -107,19 +107,18 @@ With the source generator, you only need to annotate your fields:
 
 ```csharp
 using ThunderDesign.Net.Threading.Attributes;
+
 public partial class Person 
-{ 
-    [BindableProperty] 
+{
+    [BindableProperty]
     private string _name;
 
     [Property]
     private int _age;
 }
 ```
 
-**What gets generated:**  
-- A public `Name` property with thread-safe getter/setter and `INotifyPropertyChanged` support.
-- A public `Age` property with thread-safe getter/setter.
+**What gets generated:**
 
 ```csharp
 using System.ComponentModel;
@@ -130,7 +129,6 @@ using ThunderDesign.Net.Threading.Interfaces;
 public partial class Person : IBindableObject, INotifyPropertyChanged
 {
     public event PropertyChangedEventHandler PropertyChanged;
-
     protected readonly object _Locker = new object();
 
     public string Name
@@ -150,18 +148,132 @@ public partial class Person : IBindableObject, INotifyPropertyChanged
 You can now use your `Person` class like this:
 
 ```csharp
-var person = new Person(); 
-person.Name = "Alice"; 
-person.Age = 30; // PropertyChanged event will be raised for Name changes if you subscribe to it.
+var person = new Person();
+person.Name = "Alice";
+person.Age = 30;
+// PropertyChanged event will be raised for Name changes if you subscribe to it.
 ```
 
-
 **No need to manually implement** property notification, thread safety, or boilerplate code—the generator does it for you!
 
-> For more advanced scenarios, you can use attribute parameters to control property behavior (e.g., read-only, also notify other properties, etc.).
+> For more advanced scenarios, you can use attribute parameters to control property behavior (e.g., read-only, also notify other properties, or control accessor/property visibility).
 
+---
 
-----
+### Advanced: Customizing Getter and Setter Accessors
+
+You can control the visibility of the generated property's getter and setter using the `AccessorAccessibility` enum.  
+The property itself will use the most accessible (widest) of the getter or setter's accessibilities.
+
+#### Example
+
+```csharp
+using ThunderDesign.Net.Threading.Attributes;
+using ThunderDesign.Net.Threading.Enums;
+
+public partial class Person
+{
+    // Public getter, private setter (property will be public)
+    [BindableProperty(getter: AccessorAccessibility.Public, setter: AccessorAccessibility.Private)]
+    private string _name;
+
+    // Internal getter, protected setter (property will be internal)
+    [Property(getter: AccessorAccessibility.Internal, setter: AccessorAccessibility.Protected)]
+    private int _age;
+}
+```
+
+**What gets generated:**
+```csharp
+public partial class Person
+{
+    public string Name
+    {
+        get { return this.GetProperty(ref _name, _Locker); }
+        private set { this.SetProperty(ref _name, value, _Locker, true); }
+    }
+
+    internal int Age
+    {
+        internal get { return this.GetProperty(ref _age, _Locker); }
+        protected set { this.SetProperty(ref _age, value, _Locker); }
+    }
+}
+
+```
+
+> The property will be as accessible as its most accessible accessor (getter or setter).
+> The default for `getter`, and `setter` is `public` if not specified.
+
+**Available options for `AccessorAccessibility`:**
+- `Public`
+- `Private`
+- `Protected`
+- `Internal`
+- `ProtectedInternal`
+- `PrivateProtected`
+
+---
+
+### Advanced: Notify Other Properties
+
+You can notify other properties when a specific property changes by using the `alsoNotify` parameter in the `[BindableProperty]` attribute.
+
+#### Example
+```csharp
+using ThunderDesign.Net.Threading.Attributes;
+
+public partial class Person
+{
+    [BindableProperty(alsoNotify: new[] { nameof(DisplayName) })]
+    private string _firstName;
+
+    [BindableProperty(alsoNotify: new[] { nameof(DisplayName) })]
+    private string _lastName;
+
+    public string DisplayName => $"{FirstName} {LastName}";
+}
+```
+
+**What gets generated:**
+
+```csharp
+public partial class Person : IBindableObject, INotifyPropertyChanged
+{
+    public event PropertyChangedEventHandler PropertyChanged;
+    protected readonly object _Locker = new object();
+
+    public string FirstName
+    {
+        get { return this.GetProperty(ref _firstName, _Locker); }
+        set
+        {
+            if (this.SetProperty(ref _firstName, value, _Locker, true))
+            {
+                this.OnPropertyChanged(nameof(DisplayName));
+            }
+        }
+    }
+
+    public string LastName
+    {
+        get { return this.GetProperty(ref _lastName, _Locker); }
+        set
+        {
+            if (this.SetProperty(ref _lastName, value, _Locker, true))
+            {
+                this.OnPropertyChanged(nameof(DisplayName));
+            }
+        }
+    }
+
+    public string DisplayName => $"{FirstName} {LastName}";
+}
+```
+
+> This feature is particularly useful for computed properties like `DisplayName` that depend on other properties.
+
+---
 
 ## Installation
 
@@ -199,4 +311,6 @@ This can be overwritten durring creation or by setting Property `WaitOnNotifyCol
 Observable Objects Property `WaitOnNotifyPropertyChanged` has been renamed to Property `WaitOnNotifying`.
 
 Observable Collections Property `WaitOnNotifyCollectionChanged` has been removed and now uses Property `WaitOnNotifying`.
-----
+----
+
+

src/ThunderDesign.Net-PCL.SourceGenerators/PropertyGeneratorHelpers.cs renamed to src/ThunderDesign.Net-PCL.SourceGenerators/Helpers/PropertyGeneratorHelpers.cs

@@ -3,7 +3,7 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using System.Linq;
 
-namespace ThunderDesign.Net_PCL.SourceGenerators
+namespace ThunderDesign.Net.SourceGenerators.Helpers
 {
     internal static class PropertyGeneratorHelpers
     {
@@ -74,7 +74,7 @@ public static PropertyFieldInfo GetFieldWithAttribute(GeneratorSyntaxContext con
                     }
                 }
             }
-            return default(PropertyFieldInfo);
+            return default;
         }
 
         // Rule 2: Field must start with "_" followed by a letter, or a lowercase letter
@@ -123,17 +123,17 @@ public static bool EventExists(INamedTypeSymbol classSymbol, string eventName, I
         public static bool MethodExists(
             INamedTypeSymbol classSymbol,
             string methodName,
-            ITypeSymbol[]? parameterTypes = null,
-            ITypeSymbol? returnType = null)
+            ITypeSymbol[] parameterTypes = null,
+            ITypeSymbol returnType = null)
         {
             return classSymbol.GetMembers()
                 .OfType<IMethodSymbol>()
                 .Any(m =>
                     m.Name == methodName &&
                     (parameterTypes == null ||
-                        (m.Parameters.Length == parameterTypes.Length &&
+                        m.Parameters.Length == parameterTypes.Length &&
                          m.Parameters.Select(p => p.Type.ToDisplayString())
-                          .SequenceEqual(parameterTypes.Select(t => t.ToDisplayString())))) &&
+                          .SequenceEqual(parameterTypes.Select(t => t.ToDisplayString()))) &&
                     (returnType == null || SymbolEqualityComparer.Default.Equals(m.ReturnType, returnType))
                 );
         }

src/ThunderDesign.Net-PCL.SourceGenerators/ThunderDesign.Net-PCL.SourceGenerators.csproj

@@ -4,7 +4,7 @@
 		<TargetFramework>netstandard2.0</TargetFramework>
 		<LangVersion>latest</LangVersion>
 		<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
-		<RootNamespace>ThunderDesign.Net_PCL.SourceGenerators</RootNamespace>
+		<RootNamespace>ThunderDesign.Net.SourceGenerators</RootNamespace>
 		<IncludeBuildOutput>false</IncludeBuildOutput>
 		<IncludeAnalyzer>true</IncludeAnalyzer>
 		<!-- NuGet package metadata -->