Probable error in cosine similarity

[gyrdym]

fonnx/lib/extensions/vector.dart

Line 7 in ac30c6f

return 1.0 - distance;

Hello,

Being an author of ml_linalg library, I found an error here.

In fact, 1-* is already considered in Vector.distanceTo:

https://github.com/gyrdym/ml_linalg/blob/027ddfab120b1e2d0c4d6b676c31e62615ce2374/lib/src/vector/float32x4_vector.dart#L521

P.S. Your library is awesome!

[gyrdym]

Hmm, maybe I got it wrong, since the method is called similarity - so indeed maybe you need to subtract cosine distance from 1