test(svelte-query/createMutation): simplify 'mutationFn' and replace 'queryByText' with 'getByText'

Author: sukvvon

packages/svelte-query/tests/createMutation/OnSuccessExample.svelte

@@ -2,6 +2,7 @@
   import { writable } from 'svelte/store'
   import { QueryClient } from '@tanstack/query-core'
   import { createMutation, setQueryClientContext } from '../../src/index.js'
+  import { sleep } from '@tanstack/query-test-utils'
 
   export let onSuccessMock: any
   export let onSettledMock: any
@@ -12,7 +13,7 @@
   setQueryClientContext(queryClient)
 
   const mutation = createMutation({
-    mutationFn: (vars: { count: number }) => Promise.resolve(vars.count),
+    mutationFn: (vars: { count: number }) => sleep(10).then(() => vars.count),
     onSuccess: (data) => {
       onSuccessMock(data)
     },

packages/svelte-query/tests/createMutation/ResetExample.svelte

@@ -1,16 +1,14 @@
 <script lang="ts">
   import { QueryClient } from '@tanstack/query-core'
   import { createMutation, setQueryClientContext } from '../../src/index.js'
+  import { sleep } from '@tanstack/query-test-utils'
 
   const queryClient = new QueryClient()
   setQueryClientContext(queryClient)
 
   const mutation = createMutation({
-    mutationFn: () => {
-      const err = new Error('Expected mock error')
-      err.stack = ''
-      return Promise.reject(err)
-    },
+    mutationFn: () =>
+      sleep(10).then(() => Promise.reject(new Error('Expected mock error'))),
   })
 </script>
 

packages/svelte-query/tests/createMutation/createMutation.test.ts

@@ -20,14 +20,12 @@ describe('createMutation', () => {
     expect(rendered.queryByText('Error: undefined')).toBeInTheDocument()
 
     fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
-    await vi.advanceTimersByTimeAsync(0)
-    expect(
-      rendered.queryByText('Error: Expected mock error'),
-    ).toBeInTheDocument()
+    await vi.advanceTimersByTimeAsync(11)
+    expect(rendered.getByText('Error: Expected mock error')).toBeInTheDocument()
 
     fireEvent.click(rendered.getByRole('button', { name: /Reset/i }))
-    await vi.advanceTimersByTimeAsync(0)
-    expect(rendered.queryByText('Error: undefined')).toBeInTheDocument()
+    await vi.advanceTimersByTimeAsync(11)
+    expect(rendered.getByText('Error: undefined')).toBeInTheDocument()
   })
 
   test('Able to call `onSuccess` and `onSettled` after each successful mutate', async () => {
@@ -46,7 +44,7 @@ describe('createMutation', () => {
     fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
     fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
     fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
-    await vi.advanceTimersByTimeAsync(0)
+    await vi.advanceTimersByTimeAsync(11)
     expect(rendered.queryByText('Count: 3')).toBeInTheDocument()
 
     expect(onSuccessMock).toHaveBeenCalledTimes(3)
@@ -67,14 +65,11 @@ describe('createMutation', () => {
 
     const mutationFn = vi.fn<(value: Value) => Promise<Value>>()
 
-    mutationFn.mockImplementationOnce(() => {
-      return Promise.reject(`Expected mock error`)
-    })
+    mutationFn.mockImplementationOnce(() =>
+      sleep(20).then(() => Promise.reject(`Expected mock error`)),
+    )
 
-    mutationFn.mockImplementation(async (value) => {
-      await sleep(5)
-      return Promise.resolve(value)
-    })
+    mutationFn.mockImplementation((value) => sleep(10).then(() => value))
 
     const rendered = render(FailureExample, {
       props: {
@@ -86,7 +81,7 @@ describe('createMutation', () => {
 
     fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
     expect(rendered.getByText('Data: undefined')).toBeInTheDocument()
-    await vi.advanceTimersByTimeAsync(0)
+    await vi.advanceTimersByTimeAsync(21)
     expect(rendered.getByText('Status: error')).toBeInTheDocument()
     expect(rendered.getByText('Failure Count: 1')).toBeInTheDocument()
     expect(
@@ -96,7 +91,7 @@ describe('createMutation', () => {
     fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
     await vi.advanceTimersByTimeAsync(0)
     expect(rendered.getByText('Status: pending')).toBeInTheDocument()
-    await vi.advanceTimersByTimeAsync(6)
+    await vi.advanceTimersByTimeAsync(11)
     expect(rendered.getByText('Status: success')).toBeInTheDocument()
     expect(rendered.getByText('Data: 2')).toBeInTheDocument()
     expect(rendered.getByText('Failure Count: 0')).toBeInTheDocument()