-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Open
Labels
A-needs-triagingA Selenium member will evaluate this soon!A Selenium member will evaluate this soon!I-enhancementSomething could be betterSomething could be better
Description
Description
Let's see how confident we are about BiDi API. In general I like the applied approach, but with some concerns.
-
driver.AsBiDiAsync()
extension method should be finally live inAnyDriver
class. ThusAnyDriver
object is an owner of theBiDi
instance, and disposeBiDi
as soon as owner is disposed. Not sure, but I thinkIWebDriver
interface is a great candidate to have this newAsBiDiAsync()
method.
It is important. Finally we will have straightforward dependency:Selenium.Webdriver
->Selenium.WebDriver.BiDi
. - Really expose all hidden methods from users, such as
AddIntercept()
. So just make itpublic
instead ofinternal
, that's it. [🚀 Feature]: [dotnet] [bidi] Expose BiDi to be truly public low-level API #15612 - Revisit
InterceptRequestAsync()
method (and neighbors: response, auth). This method(s) provides more convenient API to intercept network. Literally saying it should be extensions built on top of already publicly available methods. -
EmptyResult
should be valid return type for all methods instead ofvoid
. [🚀 Feature]: [dotnet] [bidi] IntroduceEmptyResult
as a type #15562 - Anything else?..
Have you considered any alternatives or workarounds?
This issue is for tracking possible big changes in the approach. As soon as we resolve all of them, then we are confident with the approach and can move further (like documenting and fine tuning).
Metadata
Metadata
Assignees
Labels
A-needs-triagingA Selenium member will evaluate this soon!A Selenium member will evaluate this soon!I-enhancementSomething could be betterSomething could be better