Skip to content

Commit 1d174a0

Browse files
committed
drop react refresh packages for now
1 parent b15c9a9 commit 1d174a0

File tree

8 files changed

+190
-120
lines changed

8 files changed

+190
-120
lines changed

packages/selenium-ide/package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "selenium-ide",
3-
"version": "4.0.1-beta.5",
3+
"version": "4.0.1-beta.6",
44
"private": false,
55
"description": "Selenium IDE electron app",
66
"author": "Todd <tarsitodd@gmail.com>",
@@ -117,7 +117,6 @@
117117
"@fontsource/roboto": "^5.0.8",
118118
"@mui/icons-material": "^5.15.13",
119119
"@mui/material": "^5.15.13",
120-
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.11",
121120
"@seleniumhq/code-export-csharp-nunit": "^4.0.3",
122121
"@seleniumhq/code-export-csharp-xunit": "^4.0.3",
123122
"@seleniumhq/code-export-java-junit": "^4.0.3",
@@ -128,7 +127,7 @@
128127
"@seleniumhq/side-api": "^4.0.6",
129128
"@seleniumhq/side-commons": "^4.0.1",
130129
"@seleniumhq/side-model": "^4.0.1",
131-
"@seleniumhq/side-runtime": "^4.0.5",
130+
"@seleniumhq/side-runtime": "^4.0.6",
132131
"dnd-core": "^16.0.1",
133132
"electron-chromedriver": "^28.0.0",
134133
"electron-log": "^5.1.0",
@@ -167,7 +166,6 @@
167166
"html-webpack-plugin": "^5.5.3",
168167
"mini-css-extract-plugin": "^2.7.6",
169168
"npm-run-all": "^4.1.5",
170-
"react-refresh-typescript": "^2.0.9",
171169
"run-script-os": "^1.1.6",
172170
"source-map-loader": "^4.0.1",
173171
"source-map-support": "^0.5.21",

packages/selenium-ide/webpack.config.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
1-
import ReactRefreshWebpackPlugin from '@pmmmwh/react-refresh-webpack-plugin'
21
import ForkTsCheckerWebpackPlugin from 'fork-ts-checker-webpack-plugin'
32
import fs from 'fs'
43
import CopyWebpackPlugin from 'copy-webpack-plugin'
54
import HtmlWebpackPlugin from 'html-webpack-plugin'
65
import kebabCase from 'lodash/fp/kebabCase'
76
import MiniCssExtractPlugin from 'mini-css-extract-plugin'
87
import path from 'path'
9-
// eslint-disable-next-line node/no-unpublished-import
10-
import ReactRefreshTypeScript from 'react-refresh-typescript'
118
import {
129
Configuration,
1310
SourceMapDevToolPlugin,
@@ -29,9 +26,6 @@ const commonPlugins: WebpackPluginInstance[] = [
2926
if (isProduction) {
3027
commonPlugins.push(new MiniCssExtractPlugin())
3128
}
32-
if (useHMR) {
33-
commonPlugins.push(new ReactRefreshWebpackPlugin())
34-
}
3529

3630
const commonConfig: Pick<
3731
Configuration,
@@ -55,9 +49,6 @@ const commonConfig: Pick<
5549
// eslint-disable-next-line node/no-unpublished-require
5650
loader: require.resolve('ts-loader'),
5751
options: {
58-
getCustomTransformers: () => ({
59-
before: [useHMR && ReactRefreshTypeScript()].filter(Boolean),
60-
}),
6152
transpileOnly: true,
6253
},
6354
},

packages/side-api/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"@seleniumhq/browser-info": "^4.0.1",
2424
"@seleniumhq/get-driver": "^4.0.1",
2525
"@seleniumhq/side-model": "^4.0.1",
26-
"@seleniumhq/side-runtime": "^4.0.5",
26+
"@seleniumhq/side-runtime": "^4.0.6",
2727
"lodash": "^4.17.21"
2828
},
2929
"devDependencies": {

packages/side-code-export/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"types": "dist/index.d.ts",
2222
"dependencies": {
2323
"@seleniumhq/side-model": "^4.0.1",
24-
"@seleniumhq/side-runtime": "^4.0.5",
24+
"@seleniumhq/side-runtime": "^4.0.6",
2525
"commander": "^9.4.0"
2626
},
2727
"gitHead": "f58e327e7616e23a3e926e4b80cf9952164e5744"

packages/side-runner/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "selenium-side-runner",
3-
"version": "4.0.4",
3+
"version": "4.0.5",
44
"private": false,
55
"description": "Run Selenium IDE projects in cli",
66
"repository": "https://github.com/SeleniumHQ/selenium-ide",
@@ -24,7 +24,7 @@
2424
"license": "Apache-2.0",
2525
"dependencies": {
2626
"@seleniumhq/side-model": "^4.0.1",
27-
"@seleniumhq/side-runtime": "^4.0.5",
27+
"@seleniumhq/side-runtime": "^4.0.6",
2828
"commander": "^11.0.0",
2929
"glob": "^10.3.1",
3030
"jest": "^29.6.0",

packages/side-runtime/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@seleniumhq/side-runtime",
3-
"version": "4.0.5",
3+
"version": "4.0.6",
44
"private": false,
55
"description": "Selenium IDE playback and execution",
66
"author": "Tomer <tomer@corevo.io>",

packages/side-runtime/src/webdriver.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,18 @@ export default class WebDriverExecutor {
192192
const { browserName, ...capabilities } = this
193193
.capabilities as ExpandedCapabilities
194194
try {
195-
const driver = await this.getDriverSync({ debug, logger })
195+
const driver = await new Promise<
196+
Awaited<ReturnType<typeof this.getDriverSync>>
197+
>((resolve, reject) => {
198+
setTimeout(() => {
199+
reject(
200+
new Error(
201+
'Driver took too long to build. This is likely an issue with the browser or driver.'
202+
)
203+
)
204+
}, 30000)
205+
this.getDriverSync({ debug, logger }).then(resolve, reject)
206+
})
196207
debug && logger.info('Driver has been built for ' + browserName)
197208
return driver
198209
} catch (e) {

0 commit comments

Comments
 (0)