Resolved all but 7 warings

Author: penavon

Rhodus_Version_3/RhodusVersionThreeProject.dproj

@@ -5,7 +5,7 @@
         <FrameworkType>None</FrameworkType>
         <MainSource>RhodusVersionThreeProject.dpr</MainSource>
         <Base>True</Base>
-        <Config Condition="'$(Config)'==''">Release</Config>
+        <Config Condition="'$(Config)'==''">Debug</Config>
         <Platform Condition="'$(Platform)'==''">Win32</Platform>
         <TargetedPlatforms>3</TargetedPlatforms>
         <AppType>Console</AppType>

Rhodus_Version_3/RhodusVersionThreeProject.res

@@ -26,7 +26,14 @@   TBuiltInConfig= class (TModuleLib)
 
 implementation
 
-Uses Windows, uSymboLTable, uVM, uStringObject, uListObject, uMemoryManager, uRhodusEngine;
+Uses Windows,
+    uSymboLTable,
+    uVM,
+    uStringObject,
+    uListObject,
+    uMemoryManager,
+    uMachineStack,
+    uRhodusEngine;
 
 // --------------------------------------------------------------------------------------------
 
@@ -55,7 +62,7 @@ procedure TBuiltInConfig.showByteCode (vm : TObject);
 
 procedure TBuiltInConfig.getVersion (vm : TObject);
 begin
-  TVM (vm).push (TStringObject.create(RHODUS_VERSION));
+  TVM (vm).push (TStringObject.create(string (RHODUS_VERSION)));
 end;
 
 

Rhodus_Version_3/uBuiltInConfig.pas

@@ -156,7 +156,6 @@ procedure TBuiltInFile.openFile (vm : TObject);
 
 procedure TBuiltInFile.closeFile (vm : TObject);
 var fileHandle : integer;
-    f : TStreamReader;
     fr : TFileRecord;
 begin
    fileHandle := TVM (vm).popInteger;

Rhodus_Version_3/uBuiltInFile.pas

@@ -18,7 +18,7 @@ procedure computeBaseLineMemoryAllocated;
 procedure addGlobalMethodsToModule (module : TModuleLib);
 
 var mainModule : TModuleLib;
-    baseLineMemoryAllocated : integer;
+    baseLineMemoryAllocated : UInt64;
 
     procedure createGlobalBuiltIns;
 
@@ -100,7 +100,7 @@ procedure argMustBeNumber;
 
 function getMemoryAllocated : integer;
 var st: TMemoryManagerState; sb: TSmallBlockTypeState;
-    value : integer;
+    value : UInt64;
 begin
   getMemoryManagerState(st);
   value :=  st.TotalAllocatedMediumBlockSize + st.TotalAllocatedLargeBlockSize;
@@ -227,7 +227,7 @@ function countElements (alist : TListObject) : integer;
 
 function getDimensions (alist : TListObject; count : integer) : TIndexArray;
 var firstdim : integer;
-    i, n, dimIndex : integer;
+    n, dimIndex : integer;
     aitem : TListItem;
 begin
   firstdim := alist.list.Count;
@@ -410,13 +410,13 @@ procedure TBuiltInGlobal.readString (vm : TObject);
   nArgs := TVM (vm).popInteger;
   case nArgs of
     0 : prompt := '';
-    1 : prompt := TVM (vm).popString ().value;
+    1 : prompt := AnsiString (TVM (vm).popString ().value);
   else
     raise ERuntimeException.Create('readString takes a single string argument or none at all');
   end;
 
   if Assigned (TVM (vm).readStringCallbackPtr) then
-     s := TVM (vm).readStringCallbackPtr(prompt);
+     s := string (AnsiString (TVM (vm).readStringCallbackPtr(prompt)));
   sobj := TStringObject.create (s);
   TVM (vm).push (sObj);
 end;
@@ -432,20 +432,20 @@ procedure TBuiltInGlobal.readNumber (vm : TObject);
   nArgs := TVM (vm).popInteger;
   case nArgs of
     0 : prompt := '';
-    1 : prompt := TVM (vm).popString ().value;
+    1 : prompt := AnsiString (TVM (vm).popString ().value);
   else
     raise ERuntimeException.Create('readString takes a single string argument or none at all');
   end;
 
   if Assigned (TVM (vm).readStringCallbackPtr) then
-     s := TVM (vm).readStringCallbackPtr(prompt);
+     s := string (AnsiString (TVM (vm).readStringCallbackPtr(prompt)));
 
   while (not TryStrToInt(s, iValue)) and (not TryStrToFloat(s, dValue)) do
       begin
       if assigned (TVM (vm).printlnCallbackPtr) then
-         TVM (vm).printlnCallbackPtr ('Number error: ' + s + ' is not a number, try again');
+         TVM (vm).printlnCallbackPtr (AnsiString ('Number error: ' + s + ' is not a number, try again'));
       if Assigned (TVM (vm).readStringCallbackPtr) then
-         s := TVM (vm).readStringCallbackPtr(prompt);
+         s := string (AnsiString (TVM (vm).readStringCallbackPtr(prompt)));
       end;
   if TryStrToInt(s, iValue) then
      TVM (vm).push (iValue)

Rhodus_Version_3/uBuiltInGlobal.pas

@@ -147,7 +147,7 @@ procedure TBuiltInMatrix.getTranspose (vm : TObject);
 
 
 procedure TBuiltInMatrix.getAdd (vm : TObject);
-var m1, m2, ar : TArrayObject;
+var m1, m2 : TArrayObject;
 begin
   m2 := TVM (vm).popArray;
   m1 := TVM (vm).popArray;
@@ -159,7 +159,7 @@ procedure TBuiltInMatrix.getAdd (vm : TObject);
 
 
 procedure TBuiltInMatrix.getSub (vm : TObject);
-var m1, m2, ar : TArrayObject;
+var m1, m2 : TArrayObject;
 begin
   m2 := TVM (vm).popArray;
   m1 := TVM (vm).popArray;
@@ -266,8 +266,6 @@ procedure TBuiltInMatrix.matrixGeneralMult (vm : TObject; m : TArrayObject; x :
 
 procedure TBuiltInMatrix.getMult (vm : TObject);
 var m1, m2 : PMachineStackRecord;
-    ar : TArrayObject;
-    sum : double;
 begin
    m2 := TVM (vm).pop;
    m1 := TVM (vm).pop;

Rhodus_Version_3/uBuiltInMatrix.pas

@@ -46,7 +46,7 @@ constructor TBuiltInSys.Create;
 begin
   inherited Create ('sys', 'System module');
 
-  addStringValue ('version',  uBuiltInConfig.RHODUS_VERSION, 'returns the current version number for Rhodus', True);
+  addStringValue ('version',  string (uBuiltInConfig.RHODUS_VERSION), 'returns the current version number for Rhodus', True);
   addStringValue ('doubleFormat',  TBuiltInSys.defaultDoubleFormat, 'default output format string for double values', False);
   addStringValue ('integerFormat',  TBuiltInSys.defaultIntegerFormat, 'default output format string for integer values', False);
 

Rhodus_Version_3/uBuiltInSys.pas

@@ -54,7 +54,6 @@   TConstructAST = class(TObject)
 
     function  expect(thisToken: TTokenCode) : TASTNode;
     function  variable: TASTNode;
-    function  parseList: TASTNode;
     function  parseIndexOrSlice : TASTNode;
     function  parseIndexedVariable : TASTNode;
     function  parseFunctionCall: TASTNode;
@@ -251,21 +250,6 @@ function TConstructAST.variable: TASTNode;
      end;
 end;
 
-// Parse a list of the form: expression ',' expression ','' etc.
-// Returns the number of items found in the list
-function TConstructAST.parseList: TASTNode;
-var node : TASTNodeList;
-begin
-  node := TASTNodeList.Create (ntNodeList);
-  node.list.Add(expression);
-  while sc.token = tComma do
-    begin
-      sc.nextToken;
-      node.list.Add(expression);
-    end;
-  exit (node);
-end;
-
 
 // Parse: x:y  :y  x:  :  x
 function TConstructAST.parseIndexOrSlice : TASTNode;
@@ -301,8 +285,7 @@ function TConstructAST.parseIndexOrSlice : TASTNode;
 // Parse something of the form variable '[' expressionList ']'
 // Such indexing applies to lists and strings
 function TConstructAST.parseIndexedVariable : TASTNode;
-var node : TASTNode;
-    nodeList : TASTNodeList;
+var nodeList : TASTNodeList;
     exp : TASTNode;
 begin
   nodelist := TASTNodeList.Create (ntNodeList);
@@ -1323,7 +1306,7 @@ function TConstructAST.forStatement: TASTNode;
   breakStack: TStack<integer>;
   assignment: TASTAssignment;
   iterationBlock: TASTIterationBlock;
-  rightSide, body, node: TASTNode;
+  body, node: TASTNode;
   lower, upper : TASTExpression;
   id : TASTIdentifier;
 begin

Rhodus_Version_3/uConstructAST.pas

@@ -36,6 +36,7 @@ implementation
 
 Uses uListObject,
      uStringObject,
+     uMachineStack,
      uVM;
 
 constructor TMethodsBase.Create;
@@ -53,9 +54,8 @@ destructor TMethodsBase.Destroy;
 
 procedure TMethodsBase.dir(vm: TObject);
 var ls : TListObject;
-    md : TMethodDetails;
 begin
-  md := TVM (vm).popMethodDetails;
+  TVM (vm).popMethodDetails;
   ls := TListObject.create (0);
   for var i := 0 to methodList.Count - 1 do
       begin

Rhodus_Version_3/uObjectSupport.pas

@@ -61,7 +61,7 @@ function myRead (const prompt : AnsiString) : PAnsiChar;
 
 procedure setColor (acolor : AnsiString);
 begin
-  uTerminal.setColor(aColor);
+  uTerminal.setColor(string (aColor));
 end;
 
 
@@ -153,7 +153,7 @@ function executeCommand (src : string) : boolean;
 var index : integer;
     helpStr : string;
 begin
-   result := False;
+   //result := False;
 
    if listOfCommands.find (getCommand (src), index) then
       begin