Apply suggestions from code review

Author: emikelsons

src/FreeModule.jl

@@ -65,4 +65,3 @@ julia> vector_space_dim(Q)
 ```
 """
 function vector_space_dim end
-vector_space_dimension(M::Union{Field, Module, MatRing}) = vector_space_dim(M)

src/Rings.jl

@@ -285,11 +285,8 @@ function krull_dim(R::Ring)
   throw(NotImplementedError(:krull_dim, R))
 end
 
-krull_dimension = krull_dim
-
 krull_dim(::Field) = 0
 krull_dim(::Integers) = 1
-vector_space_dim(::Field) = 1
 
 krull_dim(R::Union{MPolyRing, PolyRing, LaurentMPolyRing, LaurentPolyRing}) = krull_dim(coefficient_ring(R)) + nvars(R)
 krull_dim(R::Union{SeriesRing, MSeriesRing}) = krull_dim(base_ring(R)) + nvars(R)

src/exports.jl

@@ -365,7 +365,6 @@ export isomorphism
 export kernel
 export kronecker_product
 export krull_dim
-export krull_dimension
 export laurent_polynomial_ring
 export laurent_ring
 export laurent_series
@@ -592,7 +591,6 @@ export var_index
 export vars
 export vector_space
 export vector_space_dim
-export vector_space_dimension
 export weak_popov
 export weak_popov_with_transform
 export weights

test/Matrix-test.jl

@@ -117,7 +117,7 @@ end
   S1 = matrix_space(F, 3, 4)
   S2 = matrix_ring(QQ, 2)
   @test vector_space_dim(S1) == 12
-  @test vector_space_dimension(S2) == 4
+  @test vector_space_dim(S2) == 4
 end
 
 @testset "Matrix.conversion" begin