Improve comment about unquoted null values

kinghuang · kinghuang · commit 20cdb554e94e · 2024-06-28T15:56:28.000-06:00
diff --git a/target_postgres/sinks.py b/target_postgres/sinks.py
@@ -180,7 +180,8 @@ def bulk_insert_records(  # type: ignore[override]
         ]
 
         def process_column_value(data: Any, proc: Callable) -> str:
-            # If the data is null, return nothing (unquoted).
+            # If the data is null, return an unquoted, empty value.
+            # Unquoted is important here, for PostgreSQL to interpret as null.
             if data is None:
                 return ""
 

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,8 @@ def bulk_insert_records( # type: ignore[override]`
`180`	`180`	`]`
`181`	`181`
`182`	`182`	`def process_column_value(data: Any, proc: Callable) -> str:`
`183`		`- # If the data is null, return nothing (unquoted).`
	`183`	`+ # If the data is null, return an unquoted, empty value.`
	`184`	`+ # Unquoted is important here, for PostgreSQL to interpret as null.`
`184`	`185`	`if data is None:`
`185`	`186`	`return ""`
`186`	`187`