Skip to content

Commit 4491ed3

Browse files
Replaced inline flash message checks with reusable expect_flash command
1 parent 899d99c commit 4491ed3

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

cypress/e2e/ui/Settings/Application-Settings/edit_collect_logs.cy.js

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,8 @@ function resetProtocolDropdown({
165165
cy.get('#diagnostics_collect_logs .bx--btn-set button[type="Submit"]')
166166
.contains(saveButton)
167167
.click();
168-
cy.get('#main_div #flash_msg_div .alert-success').contains(
169-
'Log Depot Settings were saved'
170-
);
168+
// Validating confirmation flash message
169+
cy.expect_flash(flashTypeSuccess, flashMessageSettingsSaved);
171170
}
172171
}
173172
);
@@ -190,10 +189,8 @@ function cancelButtonValidation() {
190189
.contains(cancelButton)
191190
.should('be.enabled')
192191
.click();
193-
// Validating confirmation alert text displayed
194-
cy.get('#main_div #flash_msg_div .alert-success').contains(
195-
'Edit Log Depot settings was cancelled by the user'
196-
);
192+
// Validating confirmation flash message
193+
cy.expect_flash(flashTypeSuccess, flashMessageOperationCanceled);
197194
}
198195

199196
function resetButtonValidation() {
@@ -231,10 +228,8 @@ function saveButtonValidation() {
231228
.contains(saveButton)
232229
.should('be.enabled')
233230
.click();
234-
// Validating confirmation alert text displayed
235-
cy.get('#main_div #flash_msg_div .alert-success').contains(
236-
'Log Depot Settings were saved'
237-
);
231+
// Validating confirmation flash message
232+
cy.expect_flash(flashTypeSuccess, flashMessageSettingsSaved);
238233
}
239234

240235
describe('Automate Collect logs Edit form operations', () => {

0 commit comments

Comments
 (0)