Fix: Activation of unknown key sets current rev

Fixes #14

Author: LevelbossMike

lib/redis.js

@@ -51,21 +51,18 @@ module.exports = CoreObject.extend({
     var uploadKey = this._currentKey();
     var that      = this;
 
-    return new RSVP.Promise(function(resolve, reject) {
-      that._list()
-        .then(function(uploads) {
-          return uploads.indexOf(revisionKey) > -1 ? resolve() : reject();
-        })
-        .then(function() {
-          return that.client.set(uploadKey, revisionKey);
-        })
-        .then(resolve);
-    })
-    .then(this._activationSuccessfulMessage)
-    .then(this._printSuccessMessage.bind(this))
-    .catch(function() {
-      return this._printErrorMessage(this._revisionNotFoundMessage());
-    }.bind(this));
+    return this._list()
+      .then(function(uploads) {
+        return uploads.indexOf(revisionKey) > -1 ? RSVP.resolve() : RSVP.reject();
+      })
+      .then(function() {
+        return that.client.set(uploadKey, revisionKey);
+      })
+      .then(this._activationSuccessfulMessage)
+      .then(this._printSuccessMessage.bind(this))
+      .catch(function() {
+        return this._printErrorMessage(this._revisionNotFoundMessage());
+      }.bind(this));
   },
 
   _list: function() {

node_tests/unit/lib/redis-test.js

@@ -262,6 +262,23 @@ describe('RedisAdapter', function() {
 
             return expect(activation).to.be.rejectedWith(SilentError, /Error!/);
           });
+
+          it('does not set the current revision when key is not in manifest', function() {
+            activation = uploadsDone
+              .then(function() {
+                return redisAdapter.activate(revisionsList[0]);
+              })
+              .then(function() {
+                return redisAdapter.activate('does-not-exist');
+              });
+              return expect(activation).to.be.rejected
+                .then(function() {
+                  return redisAdapter._current();
+                })
+                .then(function(currentRevision) {
+                  return expect(currentRevision).to.eql(revisionsList[0]);
+                });
+          });
         });
 
         describe('#_current', function() {